Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier language for description of Waypoint: Passing Values to Functions with Arguments #5807

Closed
wants to merge 6 commits into from
Closed

Easier language for description of Waypoint: Passing Values to Functions with Arguments #5807

wants to merge 6 commits into from

Conversation

krisgesling
Copy link
Contributor

Replaced existing first sentence:
"Functions can take input with parameters. Parameters are local variables that take on the value of the arguments which are passed into the function."

With user suggested sentence:
"Parameters are variables that act as placeholders for the values that are to be input to a function when it is called. When a function is defined, it is typically defined along with one or more parameters. The actual values that are input (or "passed") into a function when it is called are known as arguments."

closes #5800

Replaced existing sentence:
"Functions can take input with parameters. Parameters are local variables that take on the value of the arguments which are passed into the function."
With user suggested sentence:
"Parameters are variables that act as placeholders for the values that are to be input to a function when it is called. When a function is defined, it is typically defined along with one or more parameters. The actual values that are input (or "passed") into a function when it is called are known as arguments."
@SaintPeter
Copy link
Member

It looks like the original first sentence is still there, making it pretty redundant?

@krisgesling
Copy link
Contributor Author

Damn sorry, I've removed the old line now.

I went through it all a few times as I was figuring out the commit process. Didn't realise you couldn't use the browser editor so went and did it from scratch in c9.io and obviously missed a pretty crucial point.

@SaintPeter
Copy link
Member

Please squash your commits. Otherwise this looks good.

HoBi and others added 5 commits January 3, 2016 23:52
Link to HelpContributors room is fixed.

Added other wiki articles related to contributing to FCC that were not
referenced before in a resources section at the bottom
@krisgesling
Copy link
Contributor Author

woah, I clearly did something wrong - maybe easiest to just reject this PR outright if that doesn't affect the other commits listed? Or if I just delete my whole repo, will that wipe all of this mess that I've made?

I was trying to rebase and clean up the different branches I'd made while messing around in my own repo. Don't really understand how I've pulled in other peoples commits but I don't want to mess with them without knowing 100% what I'm doing is right.

Very sorry for the mess around everyone!

Edit: I've been tracing back my errors - I'm fairly sure this is because I attempted to address the fast-forward error when I missed the -f flag on the squashed push. So on the one hand I'm glad that these are all accepted commits already and I'm guessing I can't really affect them, on the other hand I'm feeling pretty noobish right now but I need to take it all as a learning experience.

@SaintPeter SaintPeter closed this Jan 4, 2016
@SaintPeter
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants