Fixed regexp on both ul and li opening tags #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... probably not necessary since FCC is using a loose matching system. I'll stick with your way then if that's how you've been doing it. I'll update the PR. Thanks for letting me know though. I usually try to scan over the files and see how you normally do things because I don't want to deviate from the norm but I totally missed that one. |
|
Great! Thanks! I'll accept this updated pull request. Thanks again for all your help :) |
QuincyLarson
pushed a commit
that referenced
this pull request
Jun 9, 2015
Fixed regexp on both ul and li opening tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #864
The
ulandliopening tags will now return true if a class happens to be added to either of them.