Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified instructions for the Challenge Target the same element with… #9313

Closed
wants to merge 1 commit into from
Closed

Clarified instructions for the Challenge Target the same element with… #9313

wants to merge 1 commit into from

Conversation

jodoint
Copy link

@jodoint jodoint commented Jun 23, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Added additional instruction regarding multiple jQuery Selectors. Emphasized adding multiple classes in three different ways using multiple calls of the .addClass function. Also added a note to that each class is only targeting one element at a time.

… multiple jQuery Selectors

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 23, 2016
@raisedadead
Copy link
Member

Hi @jodoint, thanks a lot for the PR but unfortunately we already have another request with #9299 already in place.

Hence we would have to close yours in favor of that. Just for the fact theirs is an older request.
Please do not get discouraged by this, and work on any of the open issues, if you may.
We sincerely thank you for the time and effort spent on putting this together and apologize for closing it.

Thanks, and happy fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants