Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for Delete Properties from a JavaScript Object #9453

Merged

Conversation

dakshshah96
Copy link
Contributor

@dakshshah96 dakshshah96 commented Jun 29, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

The current tests are checking if a property of myDogs is undefined, while not checking if the object has been mutated. The regex check is not a good metric to catch this.

We can fix this by adding an additional condition to the tests.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 29, 2016
@ghost
Copy link

ghost commented Jul 1, 2016

LGTM 👍

Thanks for contributing 🎉

@ghost ghost merged commit dfa576b into freeCodeCamp:staging Jul 1, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 1, 2016
@dakshshah96 dakshshah96 deleted the fix/delete-properties-test-challenge branch July 1, 2016 08:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants