feat(auth): Implement Passwordless Authentication #9660

raisedadead · 2016-07-10T13:37:54Z

Feature Checklist:

Closes #8165
Closes #9027
Closes #15254

QuincyLarson · 2016-08-31T06:57:00Z

@atjonathan @raisedadead @BerkeleyTrue I have created a new issue related to this here: #10407

BerkeleyTrue · 2016-08-31T18:48:55Z

@raisedadead Please continue to work on this. #10407 does not change the user stories of this PR.

QuincyLarson · 2016-08-31T18:48:57Z

Reopening this because the underlying passwordless functionality is still needed for updating the workflow.

QuincyLarson · 2016-09-04T04:13:37Z

@raisedadead I know you're recovering from the flu. I just wanted to check and see how this is coming along, and let you know that going passwordless is still a priority for us 😄

raisedadead · 2016-09-08T17:47:09Z

Hi @QuincyLarson, just got back. I plan to work on this from tomorrow. Sorry about the delay.

QuincyLarson · 2016-09-08T20:03:06Z

@raisedadead no need to apologize - thanks for helping us implement this!

raisedadead · 2016-10-06T21:18:03Z

Just a rebase of the mess that I created. Will be ready with the feature in the next push.

BerkeleyTrue · 2016-10-06T21:19:38Z

👍

raisedadead · 2016-10-20T06:00:56Z

Basic functionality is there out now… just some more validation touches and code optimisations and we are good (soon).

QuincyLarson · 2016-10-20T07:36:49Z

@raisedadead awesome - thank you for keeping us posted 😄

raisedadead · 2016-10-31T20:02:57Z

~~This is mostly ready, but am at my wit's end for getting the request to complete when the link in the email is completed.~~

~~Basically I need to get the middleware invalidateAuthToken function to execute correctly.~~

Would appreciate a review and guidance from anyone.

raisedadead · 2016-11-01T05:30:40Z

Never mind my last comment. I figured out that I was just more sleepy than I should have been last night.

This is ready for QA.

common/models/user.js

+    if (!isEmail(email)) {
+      return Promise.reject(
+        new Error('The submitted email not valid.')
+        );


common/models/user.js

+      email: email,
+      emailVerified: false
+    };
+    return User.findOrCreate$({ where: { email: userObj.email }}, userObj)


common/models/user.js

+      .map(([ err, user, isCreated ]) => {
+        if (err) {
+          return dedent`
+           Oops, something is not right, please try again later.`;


common/models/user.js

+              'a few seconds';
+            debug('request before wait time : ' + timeToWait);
+            return dedent`
+              Please wait ${timeToWait} to resend an authentication link.`;


common/models/user.js

+        let emailTemplate = 'user-request-sign-in.ejs';
+        if (isCreated) {
+          emailTemplate = 'user-request-sign-up.ejs';
+        }


common/models/user.js

+
+        return dedent`
+           If you entered a valid email, a magic link is on its way.
+           Please follow that link to sign in.`;


common/models/user.js

+      .map((msg) => {
+        if (msg) { return msg; }
+        return dedent`
+         Oops, something is not right, please try again later.`;


common/models/user.js

+        return dedent`
+         Oops, something is not right, please try again later.`;
+      })
+      .catch(error => {


common/models/user.js

-      return Observable.throw(new Error(
-        `Please wait ${timeToWait} to resend email verification.`
-      ));
+    if (!isDev) {


server/boot/user.js

@@ -152,6 +153,9 @@ module.exports = function(app) {
    );
  }

+  AccessToken.findOne$ = Observable.fromNodeCallback(


common/models/user.js

+      emailVerified: false
+    };
+    return User.findOrCreate$({ where: { email }}, userObj)
+      .map(([ err, user, isCreated ]) => {


Allows setting the SES_ID, SES_SECRET and EMAIL_SENDER values

camperbot · 2017-08-29T18:43:20Z

@raisedadead updated the pull request.

BerkeleyTrue · 2017-08-29T22:03:10Z

woot!!

raisedadead · 2017-08-31T05:41:21Z

@BerkeleyTrue this is ready for QA. Please check when you can. Thanks.

BerkeleyTrue · 2017-09-01T21:47:53Z

Looks good. I'll merge when I get to a computer

BerkeleyTrue · 2017-09-02T02:09:24Z

merged!!!!!!!!!!!!!!!!!!!!
61d740b

✨ 🎊 🚀

I owe you a 🍺

Happy Coding!

raisedadead · 2017-09-02T04:44:55Z

@BerkeleyTrue awesome, thanks a lot for the QA. Do let me know how it goes when deployed?
Of course, let's grab some 🍺 when we do meet in person in future! 😄

raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jul 10, 2016

raisedadead self-assigned this Jul 10, 2016

ghost assigned BerkeleyTrue and ghost Jul 10, 2016

ghost removed their assignment Jul 31, 2016

raisedadead changed the title ~~[WIP] Implement Passwordless Authentication~~ Implement Passwordless Authentication Oct 31, 2016

raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Nov 1, 2016

BerkeleyTrue suggested changes Nov 9, 2016

View reviewed changes

raisedadead changed the title ~~Implement Passwordless Authentication~~ [WIP] Implement Passwordless Authentication Nov 20, 2016

raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Nov 20, 2016

BerkeleyTrue reviewed Dec 22, 2016

View reviewed changes

common/models/user.js Outdated

emailVerified: false

};

return User.findOrCreate$({ where: { email }}, userObj)

.map(([ err, user, isCreated ]) => {

This comment was marked as off-topic.

Sign in to view

BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 17, 2017

raisedadead added the in progress label Apr 23, 2017

raisedadead added 18 commits August 29, 2017 23:03

Add invalidate token handler

5c13eeb

Fix indenting and remove isDev from wait time.

8b528e2

Donot render per request email

4fd43e3

Remove error catch and use update method

533d080

Unify signin and signup with lesser clicks

eb25f04

Remove sign up page and update button styles

ff652e9

Remove reset-password logic

7a49864

Remove non-react Update email views and routes

394c250

chore(passwordless): Update to freeCodeCamp

009a4f5

Update email views and notifications

f7db20f

refactor(code): cleanup and rebase

4398be5

fix(email): allow sender email var for development

fb48b61

Allows setting the SES_ID, SES_SECRET and EMAIL_SENDER values

fix: Add error handling and refactoring of Observable methods

df24cb0

fix(email): Error messages for updateEmail API

49925c9

feat(server): Add URL utils to compute server URL, HOST, PORT, etc.

4f4cd96

fix(email): Add a trailing slash to avoid redirects

e230b1e

fix(email-auth): add disable and loading indication to button

343d2d5

fix(auth): Fix merge errors from rebase

0455d20

raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Aug 29, 2017

raisedadead removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Aug 31, 2017

raisedadead mentioned this pull request Aug 31, 2017

Update email should not modify user object before its confirmed #15822

Closed

BerkeleyTrue closed this Sep 2, 2017

BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 2, 2017

raisedadead deleted the feature/passwordless-login branch September 2, 2017 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(auth): Implement Passwordless Authentication #9660

feat(auth): Implement Passwordless Authentication #9660

raisedadead commented Jul 10, 2016 •

edited

Loading

QuincyLarson commented Aug 31, 2016

BerkeleyTrue commented Aug 31, 2016

QuincyLarson commented Aug 31, 2016

QuincyLarson commented Sep 4, 2016

raisedadead commented Sep 8, 2016

QuincyLarson commented Sep 8, 2016

raisedadead commented Oct 6, 2016

BerkeleyTrue commented Oct 6, 2016

raisedadead commented Oct 20, 2016

QuincyLarson commented Oct 20, 2016

raisedadead commented Oct 31, 2016 •

edited

Loading

raisedadead commented Nov 1, 2016

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

camperbot commented Aug 29, 2017

BerkeleyTrue commented Aug 29, 2017

raisedadead commented Aug 31, 2017

BerkeleyTrue commented Sep 1, 2017

BerkeleyTrue commented Sep 2, 2017

raisedadead commented Sep 2, 2017

feat(auth): Implement Passwordless Authentication #9660

feat(auth): Implement Passwordless Authentication #9660

Conversation

raisedadead commented Jul 10, 2016 • edited Loading

QuincyLarson commented Aug 31, 2016

BerkeleyTrue commented Aug 31, 2016

QuincyLarson commented Aug 31, 2016

QuincyLarson commented Sep 4, 2016

raisedadead commented Sep 8, 2016

QuincyLarson commented Sep 8, 2016

raisedadead commented Oct 6, 2016

BerkeleyTrue commented Oct 6, 2016

raisedadead commented Oct 20, 2016

QuincyLarson commented Oct 20, 2016

raisedadead commented Oct 31, 2016 • edited Loading

raisedadead commented Nov 1, 2016

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

camperbot commented Aug 29, 2017

BerkeleyTrue commented Aug 29, 2017

raisedadead commented Aug 31, 2017

BerkeleyTrue commented Sep 1, 2017

BerkeleyTrue commented Sep 2, 2017

raisedadead commented Sep 2, 2017

raisedadead commented Jul 10, 2016 •

edited

Loading

raisedadead commented Oct 31, 2016 •

edited

Loading