Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README-FA.md #478

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Update README-FA.md #478

merged 3 commits into from
Nov 3, 2020

Conversation

Hessam-Emami
Copy link
Contributor

fix #475
this PR aims to improve the translations of the Farsi version of the README file

@erictleung
Copy link
Member

@Hessam-Emami thanks for the pull request! I don't know Persian/Farsi so, I'm unable to properly review this pull request. If possible, please find a friend or other contributor who knows Persian/Farsi who can review this. Thanks!

@Hessam-Emami
Copy link
Contributor Author

@erictleung You are right, I just checked the git history for the commits on the Farsi version of the file and it seems @BaseMax was the one who originally created it.
Dear @BaseMax, If you know Farsi/Persian I totally appreciate it if you take a look at my changes.
However, if Max doesn't know Persian, then I guess our only choice would be to simply trust each other :)
by the way, I'm a native Persian speaker and I also speak French and Italian besides English.

@BaseMax
Copy link
Contributor

BaseMax commented Oct 29, 2020

Hi Eric,

Sorry, I had forgotten. Some time ago, I added Persian language and I am happy that it has been noticed and is gradually improving.
Thanks to Hesam for improving the text.

I reviewed the changes and the changes are helpful and I suggest you please accept this.

After merging this, I will make other changes to the file myself.
Looking forward to hearing back from you soon!

Regards,
Max

@Hessam-Emami
Copy link
Contributor Author

@erictleung
Dear Eric,
Since @BaseMax reviewed and approved my changes. I would really appreciate it if you accept my PR.

Copy link
Member

@erictleung erictleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@erictleung erictleung merged commit 69746e8 into freeCodeCamp:master Nov 3, 2020
@erictleung
Copy link
Member

@Hessam-Emami @BaseMax thanks to you both! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persian Translation Errors
3 participants