-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README-FA.md #478
Update README-FA.md #478
Conversation
@Hessam-Emami thanks for the pull request! I don't know Persian/Farsi so, I'm unable to properly review this pull request. If possible, please find a friend or other contributor who knows Persian/Farsi who can review this. Thanks! |
@erictleung You are right, I just checked the git history for the commits on the Farsi version of the file and it seems @BaseMax was the one who originally created it. |
Hi Eric, Sorry, I had forgotten. Some time ago, I added Persian language and I am happy that it has been noticed and is gradually improving. I reviewed the changes and the changes are helpful and I suggest you please accept this. After merging this, I will make other changes to the file myself. Regards, |
@erictleung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@Hessam-Emami @BaseMax thanks to you both! ✨ |
fix #475
this PR aims to improve the translations of the Farsi version of the README file