This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
changed 8080 to 80 to fix issue #194 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @saurabh30 for the PR! 😄 |
docs/local_deploy.md
Outdated
| @@ -22,12 +22,12 @@ After this, you'll need to create your own .env file. Check out the .env.example | |||
|
|
|||
| Now run `docker-compose up`. This will run all the containers needed to launch this app, and will take some time to finish. | |||
|
|
|||
| When the process is finished, the app will be exposed on port 8080 and accessible by visiting `http://[hostname]:8080`. You may use a reverse proxy such as Nginx to serve the app on port 80. | |||
| When the process is finished, the app will be exposed on port 80 and accessible by visiting `http://[hostname]:80`. You may use a reverse proxy such as Nginx to serve the app on port 80. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
docs/local_deploy.md
Outdated
| @@ -22,12 +22,12 @@ After this, you'll need to create your own .env file. Check out the .env.example | |||
|
|
|||
| Now run `docker-compose up`. This will run all the containers needed to launch this app, and will take some time to finish. | |||
|
|
|||
| When the process is finished, the app will be exposed on port 8080 and accessible by visiting `http://[hostname]:8080`. You may use a reverse proxy such as Nginx to serve the app on port 80. | |||
| When the process is finished, the app will be exposed on port 80 and accessible by visiting `http://[hostname]:80`. You may use a reverse proxy such as Nginx to serve the app on port 80. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
docs/local_deploy.md
Outdated
|
|
||
| ###### Installation summary | ||
|
|
||
| 1. Install and run the Docker daemon. | ||
| 2. Clone the repository and change into it `git clone https://github.com/freeCodeCamp/Mail-for-Good && cd Mail-for-Good`. | ||
| 3. Run `cp .env.example .env` then open `.env` and edit it, passing in your own values. | ||
| 4. Run `docker-compose up`. Wait for it to finish. | ||
| 5. Visit `http://[hostname]:8080` or `localhost:8080` if running locally. | ||
| 5. Visit `http://[hostname]:80` or `localhost` if running locally. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
karuppiah7890
approved these changes
Sep 17, 2017
|
It also seems good to me. |
|
Same here, LGTM! :) Thanks @saurabh30 |
|
Lgtm, cheers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just replaced 8080 by 80 everywhere.