Fix emitting of boolean constants in global/static initializers

Booleans store 0/1 behind the scenes to be compatible with gcc, but fbc
stores boolean constants as 0/-1 internally. So it needs to do a
conversion to 0/1 when emitting the values. This was missing from
global/static variable initializer emitting for all backends.

http://www.freebasic.net/forum/viewtopic.php?f=3&t=24756

changelog.txt

@@ -21,6 +21,7 @@ Version 1.06.0
 - Accesses to 64bit bitfields could be miscompiled or trigger a compiler crash
 - #732: Virtual destructors couldn't be called on const objects
 - #790: Windows API and X11 bindings: Fixed some macros where macro parameters conflicted with other identifiers or FB keywords used in the macro body
+- boolean initializer values for global or static variables were not emitted properly
 
 
 Version 1.05.0

src/compiler/emit_x86.bas

@@ -6555,11 +6555,18 @@ end sub
 sub emitVARINIi( byval dtype as integer, byval value as longint )
 	dim s as string
 	s = *_getTypeString( dtype ) + " "
+
+	'' AST stores boolean true as -1, but we emit it as 1 for gcc compatibility
+	if( (dtype = FB_DATATYPE_BOOLEAN) and (value <> 0) ) then
+		value = 1
+	end if
+
 	if( ISLONGINT( dtype ) ) then
 		s += "0x" + hex( value )
 	else
 		s += str( value )
 	end if
+
 	s += NEWLINE
 	outEx( s )
 end sub

src/compiler/ir-hlc.bas

@@ -3461,11 +3461,18 @@ end sub
 
 private sub _emitVarIniI( byval sym as FBSYMBOL ptr, byval value as longint )
 	var dtype = symbGetType( sym )
+
+	'' AST stores boolean true as -1, but we emit it as 1 for gcc compatibility
+	if( (dtype = FB_DATATYPE_BOOLEAN) and (value <> 0) ) then
+		value = 1
+	end if
+
 	var l = exprNewIMMi( value, dtype )
 	if( symbIsRef( sym ) ) then
 		dtype = typeAddrOf( dtype )
 	end if
 	l = exprNewCAST( dtype, sym->subtype, l )
+
 	ctx.varini += exprFlush( l )
 	hVarIniSeparator( )
 end sub

src/compiler/ir-llvm.bas

@@ -2166,11 +2166,18 @@ end sub
 private sub _emitVarIniI( byval sym as FBSYMBOL ptr, byval value as longint )
 	hVarIniElementType( sym )
 	var dtype = symbGetType( sym )
+
+	'' AST stores boolean true as -1, but we emit it as 1 for gcc compatibility
+	if( (dtype = FB_DATATYPE_BOOLEAN) and (value <> 0) ) then
+		value = 1
+	end if
+
 	if( typeGetSize( dtype ) = 8 ) then
 		ctx.varini += hEmitLong( value )
 	else
 		ctx.varini += hEmitInt( dtype, sym->subtype, value )
 	end if
+
 	hVarIniSeparator( )
 end sub
 

tests/boolean/boolean.bas

@@ -172,7 +172,18 @@ namespace fbc_tests.boolean_.boolean_
 		CU_ASSERT_EQUAL( b, TRUE )
 	end sub
 
+	dim shared global1 as boolean = TRUE
+	dim shared global2 as boolean = FALSE
+
 	sub initializer_literal cdecl ( )
+		CU_ASSERT( global1 = TRUE )
+		CU_ASSERT( global2 = FALSE )
+
+		static static1 as boolean = TRUE
+		static static2 as boolean = FALSE
+		CU_ASSERT( static1 = TRUE )
+		CU_ASSERT( static2 = FALSE )
+
 		dim as boolean a = 0
 		CU_ASSERT_EQUAL( a, FALSE )