Fix wstring bugs in [L|R]TRIM functions #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space - In fb_wstr_CalcDiff() the original expression is optimized with a SHR expression due the divide by unsigned power of 2. This doesn't work for negative values. - Casting to intptr_t should not be needed as the pointer arithmetic alone should be sufficient to calculate distance betwee related pointers
…space - avoid returning a pointer before the first element in fb_wstr_SkipCharRev(), &s[-1] is undefined behaviour - also then avoids passing start > end pointers to fb_wstr_CalcDiff() - fb_wstr_SkipCharRev() now returns a pointer to the start of all skipped chars, or the end marker if no chars are skipped
…length string - [L]TRIM( wstring, filter ) will return a zero length string if the filter is also a zero length string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: sf.net #899 trim( wstring ) causes crash if string is single space
bugfix: sf.net #900 LTRIM and TRIM truncate result if filter is zero length string