-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dim shared byref initializer check #87
Merged
Merged
Commits on Jun 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a810c69 - Browse repository at this point
Copy the full SHA a810c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cc22e2 - Browse repository at this point
Copy the full SHA 3cc22e2View commit details -
Add test case for DIM BYREF bug #822 (fixed by a821ef5/3cc22e22)
Configuration menu - View commit details
-
Copy full SHA for c37bdf5 - Browse repository at this point
Copy the full SHA c37bdf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d5ecbe - Browse repository at this point
Copy the full SHA 1d5ecbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 392feb4 - Browse repository at this point
Copy the full SHA 392feb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3763b - Browse repository at this point
Copy the full SHA 6d3763bView commit details -
Fix emitting of CONST ref initializers (as opposed to OFFSETs)
The CONST code path in hFlushExprStatic() used the symbol type as-is, instead of converting to pointer type for references. Thus the type looked different and it attempted the astNewCONV() which could easily fail (because the init expression is a pointer, while the symbol could be anything, e.g. struct/string).
Configuration menu - View commit details
-
Copy full SHA for 616dc23 - Browse repository at this point
Copy the full SHA 616dc23View commit details
Commits on Jun 19, 2018
-
Fix hFlushExprStatic() to use full type again (regression from 616dc23)
I can't think of a test case for this though, CONSTness should have been checked before already, it shouldn't matter here when emitting. Also the full type is only used for an astNewCONV() which allows casting away CONSTness etc. anyways.
Configuration menu - View commit details
-
Copy full SHA for d015078 - Browse repository at this point
Copy the full SHA d015078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d08b88 - Browse repository at this point
Copy the full SHA 5d08b88View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.