Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dim shared byref initializer check #87

Merged
merged 9 commits into from
Jun 19, 2018
Merged

Fix dim shared byref initializer check #87

merged 9 commits into from
Jun 19, 2018

Commits on Jun 18, 2018

  1. Describe FB_SYMBATTRIB_REF better

    dkl committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    a810c69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cc22e2 View commit details
    Browse the repository at this point in the history
  3. Add test case for DIM BYREF bug #822 (fixed by a821ef5/3cc22e22)

    git bisect showed that a821ef5 already fixed this indirectly,
    by showing the following error message:
      Local symbols can't be referenced in 'Dim Byref As UDT1 UDT2.ru1 = u1'
    now since 3cc22e2 another error is shown:
      Expected constant in 'Dim Byref As UDT1 UDT2.ru1 = u1'
    dkl committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    c37bdf5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d5ecbe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    392feb4 View commit details
    Browse the repository at this point in the history
  6. Remove duplicate var

    dkl committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    6d3763b View commit details
    Browse the repository at this point in the history
  7. Fix emitting of CONST ref initializers (as opposed to OFFSETs)

    The CONST code path in hFlushExprStatic() used the symbol type as-is,
    instead of converting to pointer type for references. Thus the type
    looked different and it attempted the astNewCONV() which could easily
    fail (because the init expression is a pointer, while the symbol could
    be anything, e.g. struct/string).
    dkl committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    616dc23 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Fix hFlushExprStatic() to use full type again (regression from 616dc23)

    I can't think of a test case for this though, CONSTness should have been
    checked before already, it shouldn't matter here when emitting.
    Also the full type is only used for an astNewCONV() which allows casting
    away CONSTness etc. anyways.
    dkl committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    d015078 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d08b88 View commit details
    Browse the repository at this point in the history