audio/sidplayfp: Various improvements

* PORTVERSION --> DISTVERSION
* Use upstream release tarball instead of USE_GITHUB
* Remove USES= iconv, works fine without any helpers
* Add USES= compiler:c++17-lang
* Make ALSA and Pulseaudio audio backends optional

PR:		272154
Reported by:	diizzy

audio/sidplayfp/Makefile

@@ -1,7 +1,8 @@
 PORTNAME=	sidplayfp
-PORTVERSION=	2.5.0
-DISTVERSIONPREFIX=	v
+DISTVERSION=	2.5.0
+PORTREVISION=	1
 CATEGORIES=	audio
+MASTER_SITES=	https://github.com/lib${PORTNAME}/${PORTNAME}/releases/download/v${DISTVERSION}/
 
 MAINTAINER=	ehaupt@FreeBSD.org
 COMMENT=	Console SID/MUS player using sidplayfp
@@ -10,13 +11,9 @@ WWW=		https://github.com/libsidplayfp/sidplayfp
 LICENSE=	GPLv2
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-LIB_DEPENDS=	libasound.so:audio/alsa-lib \
-		libpulse.so:audio/pulseaudio \
-		libstilview.so:audio/libsidplayfp
+LIB_DEPENDS=	libstilview.so:audio/libsidplayfp
 
-USES=		autoreconf gettext iconv localbase:ldflags pkgconfig
-USE_GITHUB=	yes
-GH_ACCOUNT=	libsidplayfp
+USES=		compiler:c++17-lang localbase:ldflags pkgconfig
 GNU_CONFIGURE=	yes
 
 PLIST_FILES=	bin/sidplayfp \
@@ -25,12 +22,22 @@ PLIST_FILES=	bin/sidplayfp \
 		man/man1/stilview.1.gz \
 		man/man5/sidplayfp.ini.5.gz
 
-OPTIONS_DEFINE=		OUT123
+OPTIONS_DEFINE=		ALSA OUT123 PULSEAUDIO
 OPTIONS_DEFAULT=	OUT123
 
-OUT123_DESC=	Build with out123 library
+OUT123_DESC=	Audio output support via mpg123's out123 library
 
+ALSA_LIB_DEPENDS=	libasound.so:audio/alsa-lib
 OUT123_LIB_DEPENDS=	libout123.so:audio/mpg123
 OUT123_CONFIGURE_WITH=	out123
+PULSEAUDIO_LIB_DEPENDS=	libpulse.so:audio/pulseaudio
+
+pre-configure-ALSA-off:
+	${REINPLACE_CMD} -e 's|alsa >= 1.0|alsa >= 9999.0|g' \
+	    ${PATCH_WRKSRC}/configure
+
+pre-configure-PULSEAUDIO-off:
+	${REINPLACE_CMD} -e 's|libpulse-simple >= 1.0|libpulse-simple >= 9990.0|g' \
+	    ${PATCH_WRKSRC}/configure
 
 .include <bsd.port.mk>

audio/sidplayfp/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1687340264
-SHA256 (libsidplayfp-sidplayfp-v2.5.0_GH0.tar.gz) = 6782c42a40465ac1be9fdd231735c697732e0978926d1068aa17e15d131e810a
-SIZE (libsidplayfp-sidplayfp-v2.5.0_GH0.tar.gz) = 86936
+TIMESTAMP = 1687457572
+SHA256 (sidplayfp-2.5.0.tar.gz) = d66d2791f822c30ae3bbe2b8e482d6a75eca36c6df7ee5e2a7f63079ad6c0081
+SIZE (sidplayfp-2.5.0.tar.gz) = 249111