[NEW PORT] lang/tcc816 - 65816 fork of Tiny C Compiler #189
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| PORTNAME= tcc | ||
| DISTVERSION= 0.9.25 | ||
| CATEGORIES= lang | ||
| PKGNAMESUFFIX= 816 | ||
|
|
||
| MAINTAINER= freebsd@darkain.com | ||
| COMMENT= WDC 65816 fork of the Tiny C Compiler (TCC) | ||
| WWW= https://github.com/alekmaul/tcc | ||
|
|
||
| LICENSE= MIT | ||
| LICENSE_FILE_MIT= ${WRKSRC}/RELICENSING | ||
|
|
||
| USES= gmake | ||
| HAS_CONFIGURE= yes | ||
| CONFIGURE_ARGS= --prefix="${PREFIX}" --cc="${CC}" | ||
|
|
||
| USE_GITHUB= yes | ||
| GH_ACCOUNT= alekmaul | ||
| GH_TAGNAME= 10810db6 | ||
|
|
||
| PLIST_FILES= bin/816-tcc | ||
|
|
||
| .include <bsd.port.pre.mk> | ||
|
There was a problem hiding this comment. ¯_(ツ)_/¯ because I used another existing port as a template for this one... unless existing ports are bad..? There was a problem hiding this comment. You usually only add pre/options if you have if statments otherwise this include is unnecessary and/or incorrect |
||
|
|
||
| do-install: | ||
| ${INSTALL_PROGRAM} ${WRKSRC}/816-tcc ${STAGEDIR}${PREFIX}/bin/ | ||
|
|
||
| .include <bsd.port.post.mk> | ||
|
There was a problem hiding this comment. This should be defined unless you also have pre.mk/options.mk defined. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| TIMESTAMP = 1692904691 | ||
| SHA256 (alekmaul-tcc-0.9.25-10810db6_GH0.tar.gz) = e3e57f3c3045f0dbfb3955e2a427d4af27912def5c577e3e3d361e8534f91c3b | ||
| SIZE (alekmaul-tcc-0.9.25-10810db6_GH0.tar.gz) = 236850 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| A fork of the the Tiny C Compiler (TCC) for the WDC 65816 CPU | ||
|
|
||
| This CPU is used by the Super Nintendo Entertainment System (SNES) | ||
| and the Super Famicom (SFC), as well as other devices from that era. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see Porters Handbook on how to handle versions
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enlighten me. The instructions in the handbook are confusing. It doesn't have clear instructions when using a specific commit hash from a repo. I've been working with the upstream repo to fix FreeBSD specifics there, before a new point release is cut, so I'm using a specific commit hash that is known good rather than an older release that doesn't function on FreeBSD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example 17 or if upstream plans to use tags/releases --> Example 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number is the direct version forked from up-up-stream TCC. This particular fork has not established a version numbering scheme yet, its still early and its being figured out how to do things going forward. But this very much is that specific version of TCC, just with a different compile target. Stripping the version information would only serve to confuse users looking at up-up-stream documentation on CLI flags n what not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't lie about version numbering, if there's no versioning we follow what Porters Handbook says and don't make up our own. I'd suggest that you ask upstream what the plan is and if they can at least use tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't appreciate being called a liar. I didn't make anything up at all.
This is literally TCC version 0.9.25, with a different target CPU architecture, as I've already described. The only difference between base TCC and this TCC is the target CPU architecture. The entire point of this port is to have the ability to compile code for the 65816 CPU architecture.
https://github.com/alekmaul/tcc/blob/1ba6423fa111f67874649d8d72849dc8a611246e/VERSION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't say that, what I'm saying that we shouldn't make up our own versions and we follow Porters Handbook on how upstream handles versioning as closely as possible. I'm not going to spend any more time arguing about that, the currently defined version is incorrect and you can simply open an issue at upstream upstream and ask about versioning and how they'll handle it. We're not the only ones who have guidelines about this matter.
While not great 0.9.25.(g)insert-commit-date-here can be acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still missing why g is needed here? Is that because he's created his own repo? Or something else? Since he's controlling his repo, he could create a 0.9.25.{1,2,3,4} tag as he makes changes and is ready to do his release.
Though, to be honest, I thought the version was totally fine and don't understand, at all, what the issue is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g --> git - Example 17 in Porters Handbook
Controlling what repo? https://github.com/alekmaul/tcc isn't the same user?
Another issue with the current approach is if lets say next update will be 20 commits later, how do we handle that in a sane way? Still report as X and bump PORTREVISION? (That's a very bad idea)