Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Ports Collection is now git-based #250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

motminh
Copy link

@motminh motminh commented Apr 23, 2024

Pull requests are accepted at https://github.com/freebsd/freebsd-ports

@yurivict
Copy link
Member

yurivict commented Jun 20, 2024

I don't think that this is an acceptable change.

Let's say I maintain the port x/y, and someone would submit a pull request.
How would I be notified about this PR and other PRs for my ports?
Is there a mechanism of notification?
Is there a mechanism for port committers to merge/reject GitHub PRs?

@bsdimp
Copy link
Member

bsdimp commented Jun 20, 2024

Right now the volume is low enough it can be done manually. But we make no qos on these requests, and don't count it toward timeouts. For the moment, you'd find out by someone looking at things on github. And of course there's a mechanism for rejecting a change: comment on the pull request now and close it if it's bad. Just like you would in Bugzilla...

If you want, please automation join my github working group. That's the right answer long term. It hopes to get automation like this into github.

@@ -1,3 +1,3 @@
FreeBSD does not currently accept pull requests. This is a read-only mirror from SVN.
FreeBSD does accept pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make sure that people know of the still experimental nature of prs.

Comment on lines +1 to 3
FreeBSD does accept pull requests.

Please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FreeBSD does accept pull requests.
Please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).
# FreeBSD Ports Collection Contribution Guidelines
The FreeBSD Ports Collection prefers code contributions using either:
- A code review in [Phabricator](https://reviews.freebsd.org/differential)
- An attachment on a [Bugzilla ticket](https://bugs.freebsd.org)
GitHub Pull Requests are an experimental feature and should expect additional delay.
To learn more about contributing to the FreeBSD Ports Collection, please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants