em.4: add igb to name section #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concussious
force-pushed
the
em.4
branch
2 times, most recently
from
b46c829
to
3542ae1
Compare
mhorne
suggested changes
Mar 20, 2024
There was a problem hiding this comment.
This is good, but the page is also installed as "lem(4)". See the MLINKS in share/man/man4/Makefile. So please add that to the name section too. (The if_-prefixed links don't need a .Nm entry, IMO).
Also, you should check instances of "lem" and "igb" strings in the page, some of them need markup.
mhorne
reviewed
Mar 20, 2024
No need to apologize, thanks for helping me! |
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver. While here, tag SPDX, link the framework, and shuffle a sentence to fix linter warning. Co-authored-by: Mitchell Horne <mhorne063@gmail.com>
mhorne
approved these changes
Mar 21, 2024
freebsd-git
pushed a commit
that referenced
this pull request
Mar 21, 2024
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver. While here, tag SPDX, link the framework, and shuffle a sentence to fix linter warning. Co-authored-by: mhorne Reviewed by: mhorne MFC after: 1 week Pull Request: #1134
|
Thanks! Pushed to |
|
Pushed to main |
freebsd-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver. While here, tag SPDX, link the framework, and shuffle a sentence to fix linter warning. Co-authored-by: mhorne Reviewed by: mhorne MFC after: 1 week Pull Request: #1134 (cherry picked from commit 501f7e7)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 5, 2024
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver. While here, tag SPDX, link the framework, and shuffle a sentence to fix linter warning. Co-authored-by: mhorne Reviewed by: mhorne MFC after: 1 week Pull Request: freebsd/freebsd-src#1134
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 6, 2024
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver. While here, tag SPDX, link the framework, and shuffle a sentence to fix linter warning. Co-authored-by: mhorne Reviewed by: mhorne MFC after: 1 week Pull Request: freebsd/freebsd-src#1134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving first-glance comprehension that this manual page applies to igb/lem interfaces provided by the em(4) driver.
While here, tag SPDX and shuffle a sentence to fix linter warning.
Change inspired by new users on IRC erroneously looking for em0 interface for their I211 NIC, and hilariously being told to use supported hardware.