Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genet: add module (if_genet.ko) #1139

Closed
wants to merge 1 commit into from
Closed

Conversation

llfw
Copy link
Contributor

@llfw llfw commented Mar 22, 2024

The driver already had the appropriate module macros, it just wasn't hooked into the build system.

Since this device is specific to the Raspberry Pi 4, only build it for AArch64.


tested with monolithic (GENERIC) kernel and modular kernel without miibus (using miibus.ko) on an RPi4.

The driver already had the appropriate module macros, it just wasn't
hooked into the build system.

Since this device is specific to the Raspberry Pi 4, only build it for
AArch64.
Copy link
Member

@emaste emaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bsdimp bsdimp added the merged label Apr 12, 2024
@bsdimp
Copy link
Member

bsdimp commented Apr 12, 2024

This isn't ready. It fails to build standalone.
bus_if.h device_if.h ofw_bus_if.h and opt_platform.h were not listed.
Thankfully, listing all of these produces the correct result. opt_platform.h has #define FDT 1 in it and the *if.h files are generated correctly when they are missing.
LINT works
LINT-FDT works
LINT-ACPI works
standalone (make buildenv TARGET=arm64 ; cd sys/modules/genet; make) works
I suggest make universe -DWITH_ONLY_KERNELS TARGETS=arm64 for future submissions as well as a standalone build.

@bsdimp bsdimp closed this Apr 12, 2024
freebsd-git pushed a commit that referenced this pull request Apr 12, 2024
The driver already had the appropriate module macros, it just wasn't
hooked into the build system.

Since this device is specific to the Raspberry Pi 4, only build it for
AArch64.

Reviewed by: imp, emaste (earlier version)
Pull Request: #1139
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 7, 2024
The driver already had the appropriate module macros, it just wasn't
hooked into the build system.

Since this device is specific to the Raspberry Pi 4, only build it for
AArch64.

Reviewed by: imp, emaste (earlier version)
Pull Request: freebsd/freebsd-src#1139
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 8, 2024
The driver already had the appropriate module macros, it just wasn't
hooked into the build system.

Since this device is specific to the Raspberry Pi 4, only build it for
AArch64.

Reviewed by: imp, emaste (earlier version)
Pull Request: freebsd/freebsd-src#1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants