Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snd_hda(4) pin fixes realtek ALC286 #149

Closed
wants to merge 51 commits into from
Closed

snd_hda(4) pin fixes realtek ALC286 #149

wants to merge 51 commits into from

Conversation

kstaring
Copy link
Contributor

As with previous patches, earlier branches are also contained in this one. Also, pin patches were ported provided the Linux sources were clear-- entries that looked suspiciously like human error (e.g. double entries, unknown pci vendor ids) weren't ported.

@kstaring
Patch to enable correct sound output on jack plug on the Dell XPS 956…
8bb6dc1 
…0 laptop.
@kstaring
Add support for Dell Latitude E7240 audio jack output.
18c34ea 
Maybe. Let's see if this is enough to get output working.
@kstaring
rename DELL_LATITUDE_E7240 to DELL_E7240_SUBVENDOR for consistency
caa1056
@kstaring
- Added pin_patch structures to separate data from logic.
ed2704d 
- Integrated Realtek patches into new structure.
- Ported Linux ALC880 pin patches.

Missing: GPIO and function patches. Some entries on Linux did not have a valid
name in Linux' SND_PCI_QUIRK definition. Did not port NULL-name SND_PCI_QUIRKs.
Also, unidentified vendor ids and vendor generic patches were not ported yet.
@kstaring
Merge branch 'master' of https://github.com/FreeBSD/FreeBSD
a2cb632
@kstaring
Merge branch 'master' into hda_pin_fixes_realtek
f06d8ad
@kstaring
made pin patch type enum clearer, add macro for 'string' type patches
1b7cda5 
Improves readability.
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc880' into hda_pin_fixes_realtek
d2afee4
@kstaring
Also update hdaa_patches to use clearer enums..
b4060c1
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc880' into hda_pin_fixes_realtek
dacdf97
@kstaring
HDA pin fixes for ALC260 and ALC268
e97e1ab
@kstaring
HDA pin fixes for ALC260 and ALC268
97159fb
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc260_268' into hda_pin_fixes_re…
1ee2467 
…altek
@kstaring
First few ALC269 fixes
3a2b4cf
@kstaring
fix mistakes with SONY_81BBID_SUBVENDOR and ACER_TM_6293_SUBVENDOR..
3ff791c
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc260_268' into hda_pin_fixes_re…
1df99f8 
…altek
@kstaring
Merge branch 'hda_pin_fixes_realtek' into hda_pin_fixes_realtek_alc269
d8dfff5
@kstaring
Next bit of ALC269 pins
6aaef4e 
Skipped some out-ifdef'd code.
@kstaring
- added ALC269 pin patches (also an ALC271 patch as it appeared in
b884a51 
  the ALC269 table, ignored lots of other non-ALC269 entries)

Ignored some entries such as unidentified PCI vendor ids and a lot of
entries for other ALC series in the alc269_fixit array. For some reason
a lot of ALC patches are all thrown into the alc269 definitions-- messy.
@kstaring
- a bit ALC280 patches
8bf3a33
@kstaring
ALC255 pin patches
1a6200c
@kstaring
ALC256 patches
fd9a1e5
@kstaring
ALC262 patches
6438257
@kstaring
ALC282 patches
b084f29
@kstaring
ALC283 patches
ad9e159
@kstaring
ALC286 patches; these were moved from ALC296 where they were erroneou…
2b5d55f 
…sly applied
@kstaring
- correct style(9) pointer NULL check
bb4659a
@kstaring
- correct style(9) pointer NULL check
a97de1f
@kstaring
- correct style(9) pointer NULL check
3d00f38
@kstaring
- correct style(9) pointer NULL check
f03e409
@kstaring
- correct style(9) pointer NULL check
dacd016
@kstaring
- correct style(9) pointer NULL check
b7cdc15
@kstaring
- correct style(9) pointer NULL check
037a25b
@kstaring
- correct style(9) pointer NULL check
1412bf8
@kstaring
Convert magic pin values into strings.
3100be1 
The LSB in the pin configuration is not honoured yet, that's why some
pin configs weren't converted.
@kstaring
fix crash and use readable pin patch format
f6cfaa0
@kstaring
- Use decimal nid numbers instead of hex
ef59223
@kstaring
- rewrite all occurrences of hex pin patches to readable strings
8cbb6d6
@kstaring
back-port the changes in the ALC280 pull request github thread
0984d5c
@kstaring
back-port the changes in the ALC280 pull request github thread
54759ab 
Merge branch 'hda_pin_fixes_realtek_alc260_268' into hda_pin_fixes_realtek_alc269
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc269' into hda_pin_fixes_realte…
9707fee 
…k_alc271
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc271' into hda_pin_fixes_realte…
3f56ea4 
…k_alc280
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc280' into hda_pin_fixes_realte…
273ddae 
…k_alc255
@kstaring
updated the branch to incoorporate the suggestions made in the ALC280…
d6caed6 
… pull request github thread
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc255' into hda_pin_fixes_realte…
a123c64 
…k_alc256
@kstaring
updated the branch to incoorporate the suggestions made in the ALC280…
9287d34 
… pull request github thread
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc256' into hda_pin_fixes_realte…
e76c8c1 
…k_alc262
@kstaring
updated the branch to incoorporate the suggestions made in the ALC280…
5106fc7 
… pull request github thread
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc262' into hda_pin_fixes_realte…
31eede3 
…k_alc274
@kstaring
Merge branch 'hda_pin_fixes_realtek_alc274' into hda_pin_fixes_realte…
4cb5f32 
…k_alc282
@kstaring
updated the branch to incoorporate the suggestions made in the ALC280…
560da81 
… pull request github thread
@bsdimp
Copy link
Member

bsdimp commented Jun 2, 2021

I've taken all these pull requests, squashed them and forward ported them to -current. https://reviews.freebsd.org/D30619 is the review. As such, I'm going to close all these here.

@bsdimp bsdimp closed this Jun 2, 2021
freebsd-git pushed a commit that referenced this pull request Jul 3, 2021
@kstaring @bsdimp
hdaa: update pin patch configurations
ef790cc 
A number of structural changes:
  - Use decimal nid numbers instead of hex
  - updated the branch to incoorporate the suggestions made in the
    ALC280 pull request github thread
  - Convert magic pin values into strings.
  - Also update hdaa_patches to use clearer enums..
  - made pin patch type enum clearer, add macro for 'string' type
    patches
  - Added pin_patch structures to separate data from logic.
  - Integrated Realtek patches into new structure.

These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880

And have definitions for a number of Dell and HP laptops.

Much of this data has been mined fromt he tables in the Linux driver.

imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.

Pull Request:		#139
Pull Request:		#140
Pull Request:		#141
Pull Request:		#142
Pull Request:		#143
Pull Request:		#144
Pull Request:		#145
Pull Request:		#146
Pull Request:		#147
Pull Request:		#148
Pull Request:		#149
Pull Request:		#150
Differential Revision:	https://reviews.freebsd.org/D30619
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Dec 14, 2021
@kstaring @bsdjhb
hdaa: update pin patch configurations
a80725b 
A number of structural changes:
  - Use decimal nid numbers instead of hex
  - updated the branch to incoorporate the suggestions made in the
    ALC280 pull request github thread
  - Convert magic pin values into strings.
  - Also update hdaa_patches to use clearer enums..
  - made pin patch type enum clearer, add macro for 'string' type
    patches
  - Added pin_patch structures to separate data from logic.
  - Integrated Realtek patches into new structure.

These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880

And have definitions for a number of Dell and HP laptops.

Much of this data has been mined fromt he tables in the Linux driver.

imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.

Pull Request:		freebsd/freebsd-src#139
Pull Request:		freebsd/freebsd-src#140
Pull Request:		freebsd/freebsd-src#141
Pull Request:		freebsd/freebsd-src#142
Pull Request:		freebsd/freebsd-src#143
Pull Request:		freebsd/freebsd-src#144
Pull Request:		freebsd/freebsd-src#145
Pull Request:		freebsd/freebsd-src#146
Pull Request:		freebsd/freebsd-src#147
Pull Request:		freebsd/freebsd-src#148
Pull Request:		freebsd/freebsd-src#149
Pull Request:		freebsd/freebsd-src#150
Differential Revision:	https://reviews.freebsd.org/D30619
emaste pushed a commit to emaste/freebsd that referenced this pull request Mar 24, 2022
@kstaring @emaste
hdaa: update pin patch configurations
e33e6ff 
A number of structural changes:
  - Use decimal nid numbers instead of hex
  - updated the branch to incoorporate the suggestions made in the
    ALC280 pull request github thread
  - Convert magic pin values into strings.
  - Also update hdaa_patches to use clearer enums..
  - made pin patch type enum clearer, add macro for 'string' type
    patches
  - Added pin_patch structures to separate data from logic.
  - Integrated Realtek patches into new structure.

These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880

And have definitions for a number of Dell and HP laptops.

Much of this data has been mined fromt he tables in the Linux driver.

imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.

Pull Request:		freebsd#139
Pull Request:		freebsd#140
Pull Request:		freebsd#141
Pull Request:		freebsd#142
Pull Request:		freebsd#143
Pull Request:		freebsd#144
Pull Request:		freebsd#145
Pull Request:		freebsd#146
Pull Request:		freebsd#147
Pull Request:		freebsd#148
Pull Request:		freebsd#149
Pull Request:		freebsd#150
Differential Revision:	https://reviews.freebsd.org/D30619

(cherry picked from commit ef790cc)
(cherry picked from commit 29b4fa7)
(cherry picked from commit a10c85e)
(cherry picked from commit 86d69de)
freebsd-git pushed a commit that referenced this pull request Mar 24, 2022
@kstaring @emaste
hdaa: update pin patch configurations
6228b19 
A number of structural changes:
  - Use decimal nid numbers instead of hex
  - updated the branch to incoorporate the suggestions made in the
    ALC280 pull request github thread
  - Convert magic pin values into strings.
  - Also update hdaa_patches to use clearer enums..
  - made pin patch type enum clearer, add macro for 'string' type
    patches
  - Added pin_patch structures to separate data from logic.
  - Integrated Realtek patches into new structure.

These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880

And have definitions for a number of Dell and HP laptops.

Much of this data has been mined fromt he tables in the Linux driver.

imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.

Pull Request:		#139
Pull Request:		#140
Pull Request:		#141
Pull Request:		#142
Pull Request:		#143
Pull Request:		#144
Pull Request:		#145
Pull Request:		#146
Pull Request:		#147
Pull Request:		#148
Pull Request:		#149
Pull Request:		#150
Differential Revision:	https://reviews.freebsd.org/D30619

(cherry picked from commit ef790cc)
(cherry picked from commit 29b4fa7)
(cherry picked from commit a10c85e)
(cherry picked from commit 86d69de)
@emaste emaste added the merged label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
3 participants
@kstaring @bsdimp @emaste