snd_hda(4) pin fixes realtek ALC262 #146
Closed
+1,204
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe. Let's see if this is enough to get output working.
- Integrated Realtek patches into new structure. - Ported Linux ALC880 pin patches. Missing: GPIO and function patches. Some entries on Linux did not have a valid name in Linux' SND_PCI_QUIRK definition. Did not port NULL-name SND_PCI_QUIRKs. Also, unidentified vendor ids and vendor generic patches were not ported yet.
Improves readability.
Skipped some out-ifdef'd code.
the ALC269 table, ignored lots of other non-ALC269 entries) Ignored some entries such as unidentified PCI vendor ids and a lot of entries for other ALC series in the alc269_fixit array. For some reason a lot of ALC patches are all thrown into the alc269 definitions-- messy.
The LSB in the pin configuration is not honoured yet, that's why some pin configs weren't converted.
Merge branch 'hda_pin_fixes_realtek_alc260_268' into hda_pin_fixes_realtek_alc269
… pull request github thread
… pull request github thread
… pull request github thread
|
I've taken all these pull requests, squashed them and forward ported them to -current. https://reviews.freebsd.org/D30619 is the review. As such, I'm going to close all these here. |
freebsd-git
pushed a commit
that referenced
this pull request
Jul 3, 2021
A number of structural changes:
- Use decimal nid numbers instead of hex
- updated the branch to incoorporate the suggestions made in the
ALC280 pull request github thread
- Convert magic pin values into strings.
- Also update hdaa_patches to use clearer enums..
- made pin patch type enum clearer, add macro for 'string' type
patches
- Added pin_patch structures to separate data from logic.
- Integrated Realtek patches into new structure.
These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880
And have definitions for a number of Dell and HP laptops.
Much of this data has been mined fromt he tables in the Linux driver.
imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.
Pull Request: #139
Pull Request: #140
Pull Request: #141
Pull Request: #142
Pull Request: #143
Pull Request: #144
Pull Request: #145
Pull Request: #146
Pull Request: #147
Pull Request: #148
Pull Request: #149
Pull Request: #150
Differential Revision: https://reviews.freebsd.org/D30619
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Dec 14, 2021
A number of structural changes:
- Use decimal nid numbers instead of hex
- updated the branch to incoorporate the suggestions made in the
ALC280 pull request github thread
- Convert magic pin values into strings.
- Also update hdaa_patches to use clearer enums..
- made pin patch type enum clearer, add macro for 'string' type
patches
- Added pin_patch structures to separate data from logic.
- Integrated Realtek patches into new structure.
These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880
And have definitions for a number of Dell and HP laptops.
Much of this data has been mined fromt he tables in the Linux driver.
imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.
Pull Request: freebsd/freebsd-src#139
Pull Request: freebsd/freebsd-src#140
Pull Request: freebsd/freebsd-src#141
Pull Request: freebsd/freebsd-src#142
Pull Request: freebsd/freebsd-src#143
Pull Request: freebsd/freebsd-src#144
Pull Request: freebsd/freebsd-src#145
Pull Request: freebsd/freebsd-src#146
Pull Request: freebsd/freebsd-src#147
Pull Request: freebsd/freebsd-src#148
Pull Request: freebsd/freebsd-src#149
Pull Request: freebsd/freebsd-src#150
Differential Revision: https://reviews.freebsd.org/D30619
emaste
pushed a commit
to emaste/freebsd
that referenced
this pull request
Mar 24, 2022
A number of structural changes:
- Use decimal nid numbers instead of hex
- updated the branch to incoorporate the suggestions made in the
ALC280 pull request github thread
- Convert magic pin values into strings.
- Also update hdaa_patches to use clearer enums..
- made pin patch type enum clearer, add macro for 'string' type
patches
- Added pin_patch structures to separate data from logic.
- Integrated Realtek patches into new structure.
These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880
And have definitions for a number of Dell and HP laptops.
Much of this data has been mined fromt he tables in the Linux driver.
imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.
Pull Request: freebsd#139
Pull Request: freebsd#140
Pull Request: freebsd#141
Pull Request: freebsd#142
Pull Request: freebsd#143
Pull Request: freebsd#144
Pull Request: freebsd#145
Pull Request: freebsd#146
Pull Request: freebsd#147
Pull Request: freebsd#148
Pull Request: freebsd#149
Pull Request: freebsd#150
Differential Revision: https://reviews.freebsd.org/D30619
(cherry picked from commit ef790cc)
(cherry picked from commit 29b4fa7)
(cherry picked from commit a10c85e)
(cherry picked from commit 86d69de)
freebsd-git
pushed a commit
that referenced
this pull request
Mar 24, 2022
A number of structural changes:
- Use decimal nid numbers instead of hex
- updated the branch to incoorporate the suggestions made in the
ALC280 pull request github thread
- Convert magic pin values into strings.
- Also update hdaa_patches to use clearer enums..
- made pin patch type enum clearer, add macro for 'string' type
patches
- Added pin_patch structures to separate data from logic.
- Integrated Realtek patches into new structure.
These incorporate fixes for ALC255, ALC256, ALC260, ALC262, ALC268,
ALC269, ALC280, ALC282, ALC283, ALC286, ALC290, ALC293, ALC296, ALC2880
And have definitions for a number of Dell and HP laptops.
Much of this data has been mined fromt he tables in the Linux driver.
imp squashed these into one commit because the changes from the github
pull requests no longer cleanly apply individually and made light style
changes after feedback from jhb.
Pull Request: #139
Pull Request: #140
Pull Request: #141
Pull Request: #142
Pull Request: #143
Pull Request: #144
Pull Request: #145
Pull Request: #146
Pull Request: #147
Pull Request: #148
Pull Request: #149
Pull Request: #150
Differential Revision: https://reviews.freebsd.org/D30619
(cherry picked from commit ef790cc)
(cherry picked from commit 29b4fa7)
(cherry picked from commit a10c85e)
(cherry picked from commit 86d69de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with previous patches, earlier branches are also contained in this one. Also, pin patches were ported provided the Linux sources were clear-- entries that looked suspiciously like human error (e.g. double entries, unknown pci vendor ids) weren't ported.