Optimize swab so that it can take any ssize_t value #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI builds are currently broken due to 6cafdee |
RSilicon
changed the title
RSilicon
force-pushed
the
patch-19
branch
3 times, most recently
from
26318ae
to
d0263ee
Compare
RSilicon
force-pushed
the
patch-19
branch
2 times, most recently
from
ca93600
to
65ea569
Compare
RSilicon
force-pushed
the
patch-19
branch
5 times, most recently
from
d4ba7fd
to
cf69012
Compare
RSilicon
force-pushed
the
patch-19
branch
3 times, most recently
from
ec0d32d
to
9a76db3
Compare
Casting to int cuts off data on some platforms, resulting in the incorrect results for swab.
|
Pushed with tweaked commit message, documenting all the changes more fully. |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 5, 2023
Casting to int truncates size on some platforms, resulting swab not copying all the data. Cast len to size_t to avoid right shifting a signed value: we know here it's > 0, so we can safely cast it w/o losing precision. In addition, be more careful with signedness of char pointers and temporaries. Downgrade tmp from unsigned long to unsigned char since we're only reading and writing characters. Reviewed by: imp Pull Request: #516
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Mar 22, 2023
Casting to int truncates size on some platforms, resulting swab not copying all the data. Cast len to size_t to avoid right shifting a signed value: we know here it's > 0, so we can safely cast it w/o losing precision. In addition, be more careful with signedness of char pointers and temporaries. Downgrade tmp from unsigned long to unsigned char since we're only reading and writing characters. Reviewed by: imp Pull Request: freebsd/freebsd-src#516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting to int cuts off data on some platforms, resulting in the incorrect results for swab.