GitHub: Fix cross-builds #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I wasn't aware of this compat header. Should be no problem to commit this. |
|
Seems reasonable although maybe we should just copy-paste all the alignment macros from cdefs here. |
Add alignment macros to cross-build's sys/cdefs.h
|
I wonder if there's not some way that we could bring in the latest sys/cdefs.h entirely, or have a common subset we can share. cdefs.h is in need of a good scrubbing and I'd hate to have to do that multiple places... |
jlduran
force-pushed
the
fix-github-crossbuilds
branch
from
cad062e
to
4d20916
Compare
freebsd-git
pushed a commit
that referenced
this pull request
Sep 7, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: #531 MFC after: immediately (build fix)
|
Merged in 94d9439, but I don't seem to have permissions to mark this PR as closed. |
|
Thank you!
I think it’s because you are not a member of FreeBSD on GitHub 🙃. |
arichardson
pushed a commit
to arichardson/cheribsd
that referenced
this pull request
Sep 15, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
arichardson
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Sep 15, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
arichardson
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Sep 24, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
arichardson
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Sep 28, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Dec 30, 2021
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to bother (bi-weekly) @arichardson for GitHub cross-builds, sorry.
This is more an FYI than an actual PR, but this is what I did:
Add
__is_aligneddefinition to cross-build'ssys/cdefs.hThis was introduced in 4e5d32a.
PS: I did not want to hinder @DimitryAndric warning-silencing spree, that's why I decided to wait a while to submit.