-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: Fix cross-builds #531
Conversation
Ah, I wasn't aware of this compat header. Should be no problem to commit this. |
Seems reasonable although maybe we should just copy-paste all the alignment macros from cdefs here. |
Add alignment macros to cross-build's sys/cdefs.h
I wonder if there's not some way that we could bring in the latest sys/cdefs.h entirely, or have a common subset we can share. cdefs.h is in need of a good scrubbing and I'd hate to have to do that multiple places... |
cad062e
to
4d20916
Compare
Add alignment macros to cross-build's sys/cdefs.h Pull Request: #531 MFC after: immediately (build fix)
Merged in 94d9439, but I don't seem to have permissions to mark this PR as closed. |
Thank you!
I think it’s because you are not a member of FreeBSD on GitHub 🙃. |
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix) (cherry picked from commit 94d9439)
Add alignment macros to cross-build's sys/cdefs.h Pull Request: freebsd/freebsd-src#531 MFC after: immediately (build fix)
It's time to bother (bi-weekly) @arichardson for GitHub cross-builds, sorry.
This is more an FYI than an actual PR, but this is what I did:
Add
__is_aligned
definition to cross-build'ssys/cdefs.h
This was introduced in 4e5d32a.
PS: I did not want to hinder @DimitryAndric warning-silencing spree, that's why I decided to wait a while to submit.