jail: convert several functions from int to bool #663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An earlier version of this Pull Request was approved by jamie@, but it was never merged. |
jlduran
reviewed
Feb 25, 2023
sys/sys/jail.h
Outdated
| @@ -413,17 +413,17 @@ struct vfsconf; | |||
| */ | |||
| #define jailed(cred) (cred->cr_prison != &prison0) | |||
|
|
|||
| int jailed_without_vnet(struct ucred *); | |||
| boolt jailed_without_vnet(struct ucred *); | |||
There was a problem hiding this comment.
There seems to be a typo here. Should be just bool, not boolt.
There was a problem hiding this comment.
thanks for catching that
fixed!
There was a problem hiding this comment.
You are welcome, now we just need the changes to make it compile.
There was a problem hiding this comment.
looking okay now.
And would look a lot better with #668 merged.
igalic
force-pushed
the
style/jails-int-to-bool
branch
3 times, most recently
from
47f46e6
to
4af6d0c
Compare
these functions exclusively return (0) and (1), so convert them to bool We also convert some networking related jail functions from int to bool some of which were returning an error that was never used. Differential Revision: https://reviews.freebsd.org/D29659
igalic
force-pushed
the
style/jails-int-to-bool
branch
from
4af6d0c
to
6f3680a
Compare
ngortheone
approved these changes
Feb 26, 2023
|
looks good... sorry it took so long to get into the tree... |
freebsd-git
pushed a commit
that referenced
this pull request
Mar 15, 2023
these functions exclusively return (0) and (1), so convert them to bool We also convert some networking related jail functions from int to bool some of which were returning an error that was never used. Differential Revision: https://reviews.freebsd.org/D29659 Reviewed by: imp, jamie (earlier version) Pull Request: #663
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Apr 19, 2023
these functions exclusively return (0) and (1), so convert them to bool We also convert some networking related jail functions from int to bool some of which were returning an error that was never used. Differential Revision: https://reviews.freebsd.org/D29659 Reviewed by: imp, jamie (earlier version) Pull Request: freebsd/freebsd-src#663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these functions exclusively return (0) and (1), so convert them to bool
We also convert some networking related jail functions from int to bool some of which were returning an error that was never used.
Differential Revision: https://reviews.freebsd.org/D29659