GitHub: Silence clang-12 cross builds #668
Conversation
This reverts commit d6327ae.
|
I think we can just drop clang12 from the mix... unless the change to linux/unistd.h really fixes it, in which case we should do that... |
This reverts commit d6327ae. Reviewed by: imp Pull Request: freebsd#668
#678 seems working. BTW, if we're going to drop clang 12 support, we need to update https://docs.freebsd.org/en/articles/committers-guide/#_current_compiler_versions |
Yea, I think we should commit this fix, but keep clang12 since we need it still for stable/12 til its EOL. Might as well test it with a recent-ish ubuntu too. |
|
You are right! it should be kept until EOY. I just tested
|
|
Got the OK from @jrtc27 on IRC, with an appropriate commit message. |
This reverts commit d6327ae. Before version 2.25, glibc's unistd.h would define the POSIX subset of getopt.h by defining __need_getopt, including getopt.h (which would disable the header guard) and then undefining it so later including getopt.h explicitly would define the extensions. However, we wrap getopt, and so the wrapper's #pragma once breaks that. Thus getopt.h was included before the real unistd.h to ensure we get all the extensions. However, with clang 12 that causes problems where we get a function mismatch (since getopt can throw exceptions). If we include it after unistd.h, it will get the full definitions since glibc no longer does the subsetting thing. This will result in matching definitions and fix clang 12. Reviewed by: imp, jrtc27 (OK'd on irc) Pull Request: #668
This reverts commit d6327ae. Before version 2.25, glibc's unistd.h would define the POSIX subset of getopt.h by defining __need_getopt, including getopt.h (which would disable the header guard) and then undefining it so later including getopt.h explicitly would define the extensions. However, we wrap getopt, and so the wrapper's #pragma once breaks that. Thus getopt.h was included before the real unistd.h to ensure we get all the extensions. However, with clang 12 that causes problems where we get a function mismatch (since getopt can throw exceptions). If we include it after unistd.h, it will get the full definitions since glibc no longer does the subsetting thing. This will result in matching definitions and fix clang 12. Reviewed by: imp, jrtc27 (OK'd on irc) Pull Request: freebsd/freebsd-src#668 (cherry picked from commit 320e7e0)
This reverts commit d6327ae. Before version 2.25, glibc's unistd.h would define the POSIX subset of getopt.h by defining __need_getopt, including getopt.h (which would disable the header guard) and then undefining it so later including getopt.h explicitly would define the extensions. However, we wrap getopt, and so the wrapper's #pragma once breaks that. Thus getopt.h was included before the real unistd.h to ensure we get all the extensions. However, with clang 12 that causes problems where we get a function mismatch (since getopt can throw exceptions). If we include it after unistd.h, it will get the full definitions since glibc no longer does the subsetting thing. This will result in matching definitions and fix clang 12. Reviewed by: imp, jrtc27 (OK'd on irc) Pull Request: freebsd/freebsd-src#668
The main idea is to stir a discussion, rather than present this pull request as the actual fix.
Can we just remove clang-12 from the test matrix?
cc/ @jrtc27, @emaste, @bsdjhb (educated guess of reviewers)