Skip to content

Commit

Permalink
Do not drop privileges during upgrades it causes locking issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@bapt
bapt committed Jan 7, 2017
1 parent deac8af commit 6cb343a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/upgrade.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ check_vulnerable(struct pkg_audit *audit, struct pkgdb *db, int sock)
return;
}

drop_privileges();

This comment has been minimized.

Sign in to view

Copy link
@vstakhov

vstakhov Jan 7, 2017

Member

Which locking issues? It drops privs after all db manipulations are done.
if (pkg_audit_load(audit, NULL) != EPKG_OK) {
warn("unable to open vulnxml file");
fclose(out);
Expand Down

1 comment on commit 6cb343a

@bapt
Copy link
Member Author

@bapt bapt commented on 6cb343a Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it was a too quick modification, this is not the issue actually

Please sign in to comment.