mapfile: Fix fp leaks in error path

freebsd · Nov 19, 2018 · 07718b6 · 07718b6
1 parent 23069cb
commit 07718b6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/poudriere-sh/mapfile.c b/src/poudriere-sh/mapfile.c
@@ -154,12 +154,14 @@ mapfilecmd(int argc, char **argv)
 	}
 	if (fstat(fileno(fp), &sb) != 0) {
 		serrno = errno;
+		fclose(fp);
 		INTON;
 		errno = serrno;
 		err(EX_OSERR, "%s", "fstat");
 	}
 	if (!(S_ISFIFO(sb.st_mode) || S_ISREG(sb.st_mode))) {
 		serrno = errno;
+		fclose(fp);
 		INTON;
 		errno = serrno;
 		errx(EX_DATAERR, "%s not a regular file or FIFO",
@@ -182,6 +184,7 @@ mapfilecmd(int argc, char **argv)
 
 		if ((newfd = fcntl(fileno(fp), cmd, 10)) == -1) {
 			serrno = errno;
+			fclose(fp);
 			INTON;
 			errno = serrno;
 			err(EX_NOINPUT, "%s", "fcntl");