add option to delete portstree when created with -F #469
Conversation
|
Thanks for the patch. I'm not fond of another flag here. The root problem is that There's far too many flags and options here. Looking over this more, it seems that using |
|
For reference, further discussion at ba02294. |
|
True, i just tought this would also be a fast way to patch this, instead of completely rewrite the ports.sh-Script.. :-) But indeed, if a portstree is created with "-F", it always uses method "-". So reverting 7ca6e58 would be the most simple and "best" option until we find a better solution, i think. |
|
I missed saying it, but I am tempted to rip out all of this obscure stuff and simply the interface. And then add stubs to disallow the old ones. |
|
Thanks for adding the milestone @bdrewery! I hope you can fix this in 3.1.20. Have a good day |
|
Yup I am going to take a fresh look at it in the next week. |
This reverts commit c8e16f3. The -m flag is for the ports tree *update method*, not *filesystem method*. How the ports tree is updated should have no bearing on how the filesystem is treated. The -m flag was never documented as the "system ports tree" feature and thus did not resolve #250. Issue #250 Issue #469 Conflicts: src/share/poudriere/ports.sh
-M <path> must also be specified. - This implies '-f none' and '-F'. - The older '-m none' is treated like 'null' for the purposes of 'ports -d' and 'ports -u'. - 'ports -u' will not update the files. - 'ports -d' will not delete the files. - '-F' is not supported with '-m null' Issue #250 Issue #469 Issue #353 Conflicts: src/bin/poudriere.8 src/share/poudriere/ports.sh
This reverts commit ba02294. The -m flag is for the ports tree *update method*, not *filesystem method*. How the ports tree is updated should have no bearing on how the filesystem is treated. The -m flag was never documented as the "system ports tree" feature and thus did not resolve #250. Issue #250 Issue #469 Conflicts: src/share/poudriere/ports.sh
-M <path> must also be specified. - This implies '-f none' and '-F'. - The older '-m none' is treated like 'null' for the purposes of 'ports -d' and 'ports -u'. - 'ports -u' will not update the files. - 'ports -d' will not delete the files. - '-F' is not supported with '-m null' Issue #250 Issue #469 Issue #353
|
This is fixed for newly-created trees after these fixes. |
|
Thanks :) Will take a look at it and test when the new version will be released. |
When creating a portstree with the following options:
"poudriere ports -c -F -p name"
everything get's created correctly and the zfs is also made.
But since the following two commit's, it's inpossible to delete the portstree with poudriere. The only way would be to delete and clean up everything by hand, which is not a nice way and the way you want to do it.
See:
ba02294
and
7ca6e58