Skip to content

Submitting a Pull Request

edwardcwang edited this page Dec 25, 2018 · 5 revisions

So, you want to submit a pull request (PR), eh? Awesome. You are awesome. High five.

Before you hit that green submit button, there are a few things that would be great to adhere to:

Guidelines

  • Small PR => Easy to understand PR => Fast to review PR => Happy Reviewer :)

  • Bugfix should be accompanied with a corresponding test case demonstrating the bug (and it must pass).

  • Feature addition should be accompanied with a suite of tests

  • Separate functional changes from style changes (make them two separate PR's)

  • Please assign a reviewer to your case: @azidar, @jackkoenig, @donggyukim.

Thanks!!

You can’t perform that action at this time.