Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilelink: add mask rom #912

Merged
merged 1 commit into from
Aug 1, 2017
Merged

tilelink: add mask rom #912

merged 1 commit into from
Aug 1, 2017

Conversation

yunsup
Copy link
Contributor

@yunsup yunsup commented Aug 1, 2017

No description provided.

@yunsup yunsup force-pushed the add-mask-rom branch 2 times, most recently from be73862 to 454cba8 Compare August 1, 2017 04:22
@@ -0,0 +1,134 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nothing in this file relies on Python 3-only features, so it might be better to make this Python 2-compatible to save future headaches with users of this repo.

If you do choose to make this Python 2-compatible, you'll want to add the following 2- and 3-compatible shim imports:

from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, taking your comments.

@yunsup yunsup merged commit f988b91 into master Aug 1, 2017
@yunsup yunsup deleted the add-mask-rom branch August 1, 2017 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants