Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printfs were not printing register values correctly #84

Merged
merged 1 commit into from Feb 12, 2019
Merged

Printfs were not printing register values correctly #84

merged 1 commit into from Feb 12, 2019

Conversation

chick
Copy link
Collaborator

@chick chick commented Feb 8, 2019

  • Add AugmentPrintf to generate temporary registers between registers
  • call that pass at beginning of engine creation
  • make printf cache its parsed format string
  • fixed display of assigners shown at startup when setVerbose is on
    • discovered during debugging
    • showing without values should not require rollback buffers
  • remove hardcoded sorting of printf to the end of assigner list
  • fixed some leftover verbose settings in tests
  • add and augment tests of printf

@chick
Printfs were not printing register values correctly
5dd8916 
- Add AugmentPrintf to generate temporary registers between registers
- call that pass at beginning of engine creation
- make printf cache its parsed format string
- fixed display of assigners shown at startup when setVerbose is on
  - discovered during debugging
  - showing without values should not require rollback buffers
- remove hardcoded sorting of printf to the end of assigner list
- fixed some leftover verbose settings in tests
- add and augment tests of printf
@chick chick added bug Something isn't working release issue labels Feb 8, 2019
@chick chick self-assigned this Feb 8, 2019
@chick chick requested review from azidar and ucbjrl February 8, 2019 22:28
@chick chick requested a review from a team as a code owner February 8, 2019 22:28
ucbjrl
ucbjrl approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chick chick merged commit 497b6cd into master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucbjrl ucbjrl ucbjrl approved these changes

@azidar azidar Awaiting requested review from azidar

Assignees

@chick chick

Labels
bug Something isn't working release issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chick @ucbjrl