Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seed): Add tests and solution to Problem: Largest Prime Factor #15798

Merged
merged 1 commit into from
Sep 2, 2017
Merged

feat(seed): Add tests and solution to Problem: Largest Prime Factor #15798

merged 1 commit into from
Sep 2, 2017

Conversation

AungMyoKyaw
Copy link
Contributor

@AungMyoKyaw AungMyoKyaw commented Aug 24, 2017 •
edited

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 24, 2017
@camperbot
Copy link
Contributor

@AungMyoKyaw updated the pull request.

@camperbot
Copy link
Contributor

@AungMyoKyaw updated the pull request.

1 similar comment
@camperbot
Copy link
Contributor

@AungMyoKyaw updated the pull request.

@camperbot
Copy link
Contributor

@AungMyoKyaw updated the pull request.

@beaucarnes beaucarnes merged commit e3eb02e into freeCodeCamp:staging Sep 2, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 2, 2017
@beaucarnes
Copy link
Member

Merged! Thanks for the pull request.

@AungMyoKyaw AungMyoKyaw deleted the feature/euler-problem-3 branch September 4, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AungMyoKyaw @camperbot @beaucarnes @BerkeleyTrue