Skip to content

feat(seed): Add tests and solution to Problem: Largest Prime Factor#15798

Merged
beaucarnes merged 1 commit intofreeCodeCamp:stagingfrom
AungMyoKyaw:feature/euler-problem-3
Sep 2, 2017
Merged

feat(seed): Add tests and solution to Problem: Largest Prime Factor#15798
beaucarnes merged 1 commit intofreeCodeCamp:stagingfrom
AungMyoKyaw:feature/euler-problem-3

Conversation

@AungMyoKyaw
Copy link
Copy Markdown
Contributor

@AungMyoKyaw AungMyoKyaw commented Aug 24, 2017 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 24, 2017
@AungMyoKyaw AungMyoKyaw force-pushed the feature/euler-problem-3 branch from fcb4fd2 to 1b8f9d6 Compare August 25, 2017 09:16
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Aug 25, 2017

@AungMyoKyaw updated the pull request.

@AungMyoKyaw AungMyoKyaw force-pushed the feature/euler-problem-3 branch from 1b8f9d6 to db5432e Compare August 25, 2017 09:28
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Aug 25, 2017

@AungMyoKyaw updated the pull request.

1 similar comment
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Aug 25, 2017

@AungMyoKyaw updated the pull request.

@AungMyoKyaw AungMyoKyaw force-pushed the feature/euler-problem-3 branch from db5432e to b6d4264 Compare August 25, 2017 09:44
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Aug 25, 2017

@AungMyoKyaw updated the pull request.

@AungMyoKyaw AungMyoKyaw force-pushed the feature/euler-problem-3 branch from b6d4264 to 7b8256a Compare August 25, 2017 10:39
@beaucarnes beaucarnes merged commit e3eb02e into freeCodeCamp:staging Sep 2, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 2, 2017
@beaucarnes
Copy link
Copy Markdown
Member

beaucarnes commented Sep 2, 2017

Merged! Thanks for the pull request.

@AungMyoKyaw AungMyoKyaw deleted the feature/euler-problem-3 branch September 4, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AungMyoKyaw @camperbot @beaucarnes @BerkeleyTrue