New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interview-prep): Porting Rosetta problems #17537
feat(interview-prep): Porting Rosetta problems #17537
Conversation
@NitronR, thank you for porting over more problems! Just a couple of things: First, could you update your PR so that the format is like this?
The line breaks between strings in all the arrays and objects just makes it easier to read and maintain. Also, I went ahead and updated the description of "I before E except after C". You could just copy and past that over the other text. I'm still reading through the other descriptions to see if they can be updated. I'll leave more comments if I find anything. |
@NitronR updated the pull request. |
Changes are done. Also fixed some other descriptions. |
@scissorsneedfoodtoo updated the pull request. |
@scissorsneedfoodtoo updated the pull request. |
@NitronR, thank you for making all of those changes. I really like the method you used in the IBAN challenge to render the I made a couple of minor changes to the descriptions, just spacing and sentence order, really. Seems like there's a problem with the Travis CI tests, though. Going to see what the problem is there before merging. |
@NitronR updated the pull request. |
Sorry about that. Missed that final comma unlike here on my laptop. Thanks for fixing it! Pulled your PR and tested again locally. Everything seems to be fine. @raisedadead, @Bouncey, would it be alright to merge this? Or should we wait for Travis build to pass? |
@NitronR, thank you for your patience. The Travis builds are working again! Thank you for your contribution, and looking forward to the next. ✨ |
* feat(interview-prep): Porting Rosetta problems * Objects formatted and description updated. * Update rosetta-code.json * Update rosetta-code.json * Fixed syntax for Identity matrix description array
# [1.2.0](freeCodeCamp/curriculum@v1.1.3...v1.2.0) (2018-06-19) ### Bug Fixes * **challenges:** Fix typo in security challenge ([freeCodeCamp#17608](https://github.com/freeCodeCamp/curriculum/issues/17608)) ([1573455](freeCodeCamp/curriculum@1573455)) * blockquote-formatting-in-challenges ([freeCodeCamp#17590](https://github.com/freeCodeCamp/curriculum/issues/17590)) ([d31e0a3](freeCodeCamp/curriculum@d31e0a3)) ### Features * **interview-prep:** Porting Rosetta problems ([freeCodeCamp#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([a133a3f](freeCodeCamp/curriculum@a133a3f)) ### Reverts * "test(challenges): Corrected expected average value" ([freeCodeCamp#17568](https://github.com/freeCodeCamp/curriculum/issues/17568)) ([20fac4e](freeCodeCamp/curriculum@20fac4e))
* feat(interview-prep): Porting Rosetta problems * Objects formatted and description updated. * Update rosetta-code.json * Update rosetta-code.json * Fixed syntax for Identity matrix description array
# [2.0.0](freeCodeCamp/curriculum@v1.2.1...v2.0.0) (2018-06-24) ### Bug Fixes * **challenges:** Correct a regex in ES6 read-only challenge ([freeCodeCamp#41](freeCodeCamp/curriculum#41)) ([cf9336a](freeCodeCamp/curriculum@cf9336a)) * **challenges:** fix responsive web design cert claim ([6e02f9d](freeCodeCamp/curriculum@6e02f9d)) * **interview-prep:** Remove duplicates ([816be51](freeCodeCamp/curriculum@816be51)) ### Features * **interview-prep:** Porting Rosetta problems ([freeCodeCamp#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([21930a8](freeCodeCamp/curriculum@21930a8)) ### BREAKING CHANGES * **challenges:** none
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #XXXXX
Description