Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: News indexing script #36512

Merged
merged 2 commits into from Jul 29, 2019
Merged

feat: News indexing script #36512

merged 2 commits into from Jul 29, 2019

Conversation

scissorsneedfoodtoo
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo commented Jul 25, 2019 •
edited

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team July 25, 2019 14:02
@CleoAguiar
Copy link
Contributor

All checks have failed. Please put a x between square brackets in your pull requests text.
Replace [ ] to [x]

@raisedadead raisedadead self-assigned this Jul 25, 2019
@raisedadead raisedadead added the platform: search Backend indexing logic and scripts for search label Jul 25, 2019
@scissorsneedfoodtoo
Copy link
Contributor Author

@CleoAguiar, thank you for taking a look at this. You're right, I should remember to put an x between the brackets or check them off individually.

I believe the check failed due to a linting error. I'll fix this, along with updating the News theme and search bar to account for the changed property names in each article object.

@raisedadead raisedadead merged commit 9f372d0 into freeCodeCamp:master Jul 29, 2019
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the feat/news-indexing-script branch July 30, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees

@raisedadead raisedadead

Labels
platform: search Backend indexing logic and scripts for search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scissorsneedfoodtoo @CleoAguiar @raisedadead