Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): modal a11y and learn tabs on mobile #36750

Merged
merged 3 commits into from Sep 4, 2019
Merged

fix(client): modal a11y and learn tabs on mobile #36750

merged 3 commits into from Sep 4, 2019

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Sep 3, 2019 •
edited

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #36749
Closes #36691

@ahmaxed ahmaxed requested a review from a team September 3, 2019 14:16
@gitpod-io
Copy link

gitpod-io bot commented Sep 3, 2019 •
edited

@ahmaxed
Copy link
Member Author

ahmaxed commented Sep 3, 2019

this pr adds borders to modal to make them more visible.

image

@raisedadead raisedadead added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. release: next/beta scope: UI Threads for addressing UX changes and improvements to user interface labels Sep 4, 2019
@raisedadead raisedadead added this to In progress in Next via automation Sep 4, 2019
@raisedadead raisedadead changed the title Feat/modal backdrop fix(client): modal a11y and learn tabs on mobile Sep 4, 2019
@raisedadead raisedadead merged commit 5dd8044 into freeCodeCamp:master Sep 4, 2019
Next automation moved this from In progress to Done Sep 4, 2019
@ahmaxed ahmaxed deleted the feat/modal-backdrop branch October 30, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
No open projects
Next
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

learn tabs on mobile need touch up Make modals and elements high contrast
2 participants
@ahmaxed @raisedadead