New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): changed test text to use should for Front End Libraries #37762
fix(curriculum): changed test text to use should for Front End Libraries #37762
Conversation
.../english/03-front-end-libraries/bootstrap/call-out-optional-actions-with-btn-info.english.md
Outdated
Show resolved
Hide resolved
...m/challenges/english/03-front-end-libraries/bootstrap/create-a-bootstrap-headline.english.md
Outdated
Show resolved
Hide resolved
...lum/challenges/english/03-front-end-libraries/jquery/delete-your-jquery-functions.english.md
Outdated
Show resolved
Hide resolved
...lish/03-front-end-libraries/jquery/target-the-children-of-an-element-using-jquery.english.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
@moT01 I have committed your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look good to me; however, I would have preferred to have you
and your
removed from most of the comments as it seems a bit personal.
For example:
- text: You should add an <code>i</code> element with the classes <code>fas</code> and <code>fa-thumbs-up</code>.
could be rewritten
- text: An <code>i</code> element with the classes <code>fas</code> and <code>fa-thumbs-up</code> should be added.
Again, this looks good to me and I approve as-is, if you agree with what I stated above I could do the work to go through them again, just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@cmccormack According to the current Writing challenge descriptions/instructions section, the challenge text should be written using the second person "you" and most of the tests in the curriculum seem to be written this way. I do not think it necessary, but you can create a separate issue where we can all discuss it I suppose. In the mean time, I think this PR can be merged now. |
I agree that there's no need to hold this up pending a change in the style guide. |
…ies (freeCodeCamp#37762) Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Update index.md
)master
branch of freeCodeCamp.Related to PR #36860
This PR makes sure all challenges' tests in the
Front End Libraries
section use "should " or "should not".