Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user story for "for" attributes on labels in "Build a Survey Form" #38304

Closed
wants to merge 3 commits into from
Closed

Added user story for "for" attributes on labels in "Build a Survey Form" #38304

wants to merge 3 commits into from

Conversation

alti21
Copy link

@alti21 alti21 commented Feb 28, 2020

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #37961

@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2020

@RandellDawson
Copy link
Member

@alti21 Please see my comment on issue #37961.

Also, you should not be creating PRs from your master branch. Instead, you should create a branch off of your master branch to make your changes. This will keep your master branch "clean".

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Feb 29, 2020
@RandellDawson RandellDawson added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Mar 10, 2020
@raisedadead
Copy link
Member

Hi,

Thanks a lot for contribuiting.

However, since this PR was opened from a master branch of a fork, which unfortunately means we are unable to merge this because its stale with the ongoing changes.

We recommend not to use your master branch in our guidelines for contributing.

Please open a fresh request after updating your fork or deleting and creating a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"for" attributes on labels in "Build a Survey Form"
4 participants
@alti21 @RandellDawson @raisedadead @camperbot