fix(learn): remove cta and add current challenge button

[Twaha-Rahman]

Checklist:

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the master branch of freeCodeCamp.
• All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

ref #38781

Removed "If you are new to coding, we recommend you start at the beginning." message if the user has completed more than 15 challenges.

[gitpod-io]

[Twaha-Rahman]

If any additional changes are required, please let me know!

[Twaha-Rahman]

@ahmadabdolsaheb I think this PR is ready for a round of review😀

[raisedadead]

Hi @Twaha-Rahman thanks for your PR.

Quick Note: All changes are reviewed in due course. Thanks for your patience.

[raisedadead]

Closing and re-opening to Trigger CI build stall.

[gitpod-io]

[ojeytonwilliams]

I think the logic wants to be

if completedChallenge < threshold then show old text
else
show link to the current challenge

we could use https://github.com/freeCodeCamp/freeCodeCamp/blob/master/client/src/components/helpers/CurrentChallengeLink.js, with some style tweaks, to handle this.

[Twaha-Rahman]

In the issue #38781 @ahmadabdolsaheb stated this.

He wanted these two as a separate feature if I am not misunderstanding....😅

He said that-

remove "If you are new to coding, we recommend you start at the beginning." message if the user has completed a certain number of challenges.

So, should I update the PR or is this enough @ojeytonwilliams ?

[ojeytonwilliams]

Sorry, I missed that discussion. It looks to me like the final decision hasn't been made yet. Given that, please don't implement what I've suggested until that decision's been clarified, as it may not be what's wanted.

[raisedadead]

Logic states that:

For a signed in user:

1. The start here action should be when a user has less completed challenges than a certain threshold no. of challenges.

2. There should be a go to a current challenge action (a button in the stack is a good idea)
   a. Should be shown only on signed in
   b. Only when a user has completed at-least one challenge.

3. The sign in button is obviously not there in this case.

For a non-signed in user:

1. The start here action should be there always, because we do not save progress.
2. The current challenge action should not be there, because we would want them to click the "sign in and save your progress" action instead.

[ojeytonwilliams]

The stack currently being "View my Portfolio", "Update my account settings"?.

[raisedadead]

The stack currently being "View my Portfolio", "Update my account settings"?.

Yes.

[Twaha-Rahman]

Thanks a lot for clarifying guys! Much appreciated!

[Twaha-Rahman]

@ojeytonwilliams @raisedadead I've updated the PR according to the suggestions made -

1. For a signed in user:

• The start here action is shown when a user has less completed challenges than a certain threshold no. of challenges. (I have selected 15 challenges as the threshold for now)

• There is a go to a current challengebutton in the stack-
  a. Is shown only to signed in users
  b. User has to completed at-least one challenge to see this button

2. For a non-signed in user:

• The start here action is always there
• The current challenge action isn't there

[ojeytonwilliams]

When reviewing I noticed that completedChallengeCount only updates when a new user object is obtained (i.e. on page reload).

I don't think this needs fixing, since the idea is to guide people who have been away and come back, but it's a small gotcha when QAing.

[Twaha-Rahman]

@ojeytonwilliams I've fixed the problems. Ready for another round of review😁

[ojeytonwilliams]

@Twaha-Rahman thanks for making those changes. It LGTM now!

[Twaha-Rahman]

Glad I could help!