ensure nav/win are false if navigator/window undefined #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on cutting new releases and found that core integration tests were failing because the environment was referring to undefined variables. This tweak fixes that, and then I'll cut a release here and in the firefox and chrome flavors.
For the flavors, I think the only thing to do is add the provider to entry (freedomjs/freedom-for-firefox@129bab9, freedomjs/freedom-for-chrome@98aa7a2) and bump the freedom version dependency as appropriate, as this is a fairly simple provider. Let me know if I'm missing something though - thanks!