Fix issues around case-sensitive matching in poetry support #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
eloquence
reviewed
Nov 30, 2023
poetry doesn't normalize case in package names, so in securedrop-client we have jinja2 depending on "MarkupSafe", but the package itself in the lock file is named "markupsafe". We can avoid this by changing the relevant_dependencies to all be lowercase when reading them out of pyproject.toml (the "main" dependencies) and when reading from poetry.lock.
legoktm
force-pushed
the
poetry-fix-casing
branch
from
eec422b
to
5812bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poetry doesn't normalize case in package names, so in securedrop-client we have jinja2 depending on "MarkupSafe", but the package itself in the lock file is named "markupsafe".
We can avoid this by changing the relevant_dependencies to all be lowercase when reading them out of pyproject.toml (the "main" dependencies) and when reading from poetry.lock.
Test plan
PKG_DIR=../securedrop-proxy make requirementsresults in no changes