Migrate dependency management to poetry #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
only-poetry
branch
3 times, most recently
from
7ed0ffd
to
4eaabef
Compare
Merged
4 tasks
|
Going to switch this back to draft mode because it's blocked on freedomofpress/securedrop-builder#474. |
Switch dependency management to use poetry, which is much nicer than pip-tools. This is largely based off of <freedomofpress/securedrop-proxy#122> and applies the same changes to the Makefile and CI. The main difference is that we install PyQt5 via system packages, so the two versions we specifically need are listed in pyproject.toml and vary on the Python versions shipped with bullseye and bookworm. We also don't actually need the pathlib2 dependency any more because our Python version is high enough, so it's dropped now that poetry is smart enough to detect it!
|
One dependency cleared and another appears...now depends on #1674. |
|
zenmonkeykstop
previously approved these changes
Dec 11, 2023
legoktm
dismissed
zenmonkeykstop’s stale review
The merge-base changed after approval.
zenmonkeykstop
previously approved these changes
Dec 11, 2023
legoktm
dismissed
zenmonkeykstop’s stale review
The merge-base changed after approval.
zenmonkeykstop
previously approved these changes
Dec 11, 2023
legoktm
dismissed
zenmonkeykstop’s stale review
The merge-base changed after approval.
zenmonkeykstop
approved these changes
Dec 11, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch dependency management to use poetry, which is much nicer than pip-tools. This is largely based off of
freedomofpress/securedrop-proxy#122 and applies the same changes to the Makefile and CI.
The main difference is that we install PyQt5 via system packages, so the two versions we specifically need are listed in pyproject.toml and vary on the Python versions shipped with bullseye and bookworm.
Test Plan
make test, etc. all works finecheck-testing-requirements-bullseyecheck requirementChecklist