-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui polish] Reply pane styling/behavior #572
Comments
Some inspiration on how to implement this with Qt might come from a Matrix client called "Nheko-Reborn". It's cpp but the layout structure can be similar. Take a look at the source code |
@ninavizz I see that the spec does not account for a reply pane that can grow with the text like popular messenger applications. Was that considered at some point? Because it would make it much more readable not having a pane consuming 20% of the screen when nothing is typed |
So I was attempting do do this stretch goal but apparently it's more complex that I though: Because of that we probably have to make a subclass of |
While many messaging apps use this behavior, it's not clear to me that it's the best fit for SecureDrop. We have seen in user research that users don't apply a consistent paradigm to the SecureDrop client. Some map it against email, others against instant messaging. If users follow the "email" mental model, seeing your message sent immediately after pressing [Enter] may be frustrating. Given the sensitivity of these communications, and the likelihood that many interactions may involve into multi-line messages, mirroring the expectation of email-like behavior may be a better fit for SecureDrop. In an email context, Ctrl+Enter is commonly used to "send immediately". So an alternative approach would be:
I would argue that this is the safer default behavior to avoid accidental replies. Either way, we should also ensure that the user can |
Damn. Fine. Catch. @eloquence!! Thank you for your attention to this detail, in catching quite a large error of my own judgement. I agree, the "alternative" approach should be embraced, to prevent accidental replies from sending.
I also agree, that |
I didn't see any mockups for the offline mode, so I just did what I thought made sense. The current version looks like this: (over in #580) @ninavizz I think we should also add a disabled-looking airplane. What do you think? (it the last iterations of the code there were none). With the plane disabled it would look like: I already have the code for that which I can merge into #580, in case that's the way to go. |
With #580 landed, I would suggest the following next round of changes to resolve this issue (in one or multiple PRs):
[1] I would call this stretch, except that with Ctrl+Enter as the shortcut to send messages, we really need a secondary way to quickly send replies for users who won't discover this shortcut. [2] Qt's behavior here is consistent with how Chrome/Firefox handle the HTML5 placeholder attribute, though I agree w/ @creviera that in a single field form it's distracting. |
@eloquence I'm investigating the following:
|
This is probably related with the qt5 property |
This is being tracked in a smaller issue with links to relevant Zeplin screens: #593
This is not being tracked in a smaller issue right now outside of this epic
This is being tracked in a smaller issue: #594 |
@ninavizz, what happens when the user is online, has typed something in the reply box already and then clicks in the "log out" button. Is the text supposed to disappear? Is there a warning dialog saying the text will be erased? |
Good question! There should be a modal warning dialog, here—a rare situation when a modal is a GOOD thing—however, I have not yet designed that. @eloquence should Deeplow finish this Issue w/o that warning, and have us add that warning in as a separate 'feature', later, or do you want him to pause while I throw that screen together? |
That sounds like a good plan. In the first implementation, I think it's fine for the text to be quietly discarded when you log out. |
I've split the reply keyboard issue into a separate one (#606), and would propose splitting any remaining tweaks into separate smaller issues as well, closing this one. |
Closing per proposal from above. We also have #351 if we really want a tracking epic. |
Mature Reply pane implementation to align with VisDe spec
Return
key, send action is invokedshift
andReturn
keys, a new paragraph is added to their composed textCompose reply
to sit just below top of window, as shown in Zeplin mockupto:
to endCompose reply
phrase%source_name%
to follow static text, as shown in Zeplin mockupThe text was updated successfully, but these errors were encountered: