Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard reply box text when changed to offline mode #601

Open
deeplow opened this issue Oct 30, 2019 · 2 comments
Open

discard reply box text when changed to offline mode #601

deeplow opened this issue Oct 30, 2019 · 2 comments
Labels
bug Something isn't working needs discussion
Milestone

Comments

@deeplow
Copy link
Contributor

deeplow commented Oct 30, 2019

Description

Consider edge-case when the journalist has typed stuff in the reply box and and logs out.

Following a discussion in #572 (comment) a more long term solution would be a dialog, but that is still in design. This issue is for the temporary solution of discarding the text

Steps to Reproduce

  1. open client (logged in)
  2. select source
  3. type reply (but don't send it)
  4. log out

Expected Behavior

Text is discarded and default placeholder show like so.

reply-new

Actual Behavior

The text you typed show up inside the disabled reply box.

@eloquence eloquence added this to the 0.2.0beta milestone Dec 17, 2019
@eloquence eloquence modified the milestones: 0.2.xbeta, Post-Beta Mar 20, 2020
@eloquence
Copy link
Member

(Can confirm that this is still the current behavior in latest nightlies.)

@cfm
Copy link
Member

cfm commented Aug 22, 2024

NB. This is what most messaging apps mean by a "draft" message. Contrast with our DraftReply model, which is for messages either still outgoing or that previously failed to send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs discussion
Projects
None yet
Development

No branches or pull requests

4 participants