New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main window might never launch after successful login #575
Comments
eloquence
moved this from Nominated for next sprint
to Current Sprint - 10/23 -11/6
in SecureDrop Team Board
Oct 23, 2019
redshiftzero
moved this from Current Sprint - 10/23 -11/6
to In Development
in SecureDrop Team Board
Nov 5, 2019
redshiftzero
added a commit
to freedomofpress/securedrop
that referenced
this issue
Nov 5, 2019
redshiftzero
added a commit
that referenced
this issue
Nov 6, 2019
This was referenced Nov 6, 2019
option 1 fix described above is implemented in three PRs, they should be merged in the following order: |
redshiftzero
moved this from In Development
to Ready for Review
in SecureDrop Team Board
Nov 6, 2019
redshiftzero
added a commit
that referenced
this issue
Nov 10, 2019
redshiftzero
added a commit
that referenced
this issue
Nov 10, 2019
sssoleileraaa
pushed a commit
that referenced
this issue
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Here's an interesting case that can arise if a network action fails right after login but before the main window is shown - I hit this in Qubes while testing #567
STR
Login
Expected Behavior
Main window is shown.
Actual Behavior
If the network actions after the login fail, then the main window never launches, and the API actions are never retried. The application must be restarted.
Comments
This is the logic in the controller causing this issue:
on_authenticate_success
we hide the login window, we start a sync, then we useself.api.get_current_user
- this last call can fail.self.api.get_current_user
fails, thenon_get_current_user_failure
is triggered - it tries to show an error in the gui - but the gui is not displayed yet, since we display the main GUI in the success callback.In terms of how to resolve, this is happening because we want to pass a
user
object to the gui such that we can show the nice journalist icon with their name. Here are two ways to proceed:or
1 seems more straightforward to me but either should work. @creviera I vaguely recall we discussed providing the first name and last name in the response from the
/token
endpoint before, I forget why we decided not to implement it though.The text was updated successfully, but these errors were encountered: