Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add journalist first name, last name to token response #4971

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Towards freedomofpress/securedrop-client#575

Changes proposed in this pull request:

  • Simply adds the journalist first name and last name on the token response such that another round trip is not needed to fetch them on the client side.

Testing

You can follow the steps in securedrop-client PR here to test the server, SDK, and client side changes together: freedomofpress/securedrop-client#605

Deployment

deployed via securedrop-app-code package

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ran through the test plan in freedomofpress/securedrop-client#605 successfully.

@rmol rmol merged commit 4046dd3 into develop Nov 8, 2019
SecureDrop Team Board automation moved this from Ready for Review to Done Nov 8, 2019
@rmol rmol deleted the api-journo-names branch November 8, 2019 00:00
@zenmonkeykstop zenmonkeykstop mentioned this pull request Nov 22, 2019
24 tasks
@rocodes rocodes mentioned this pull request Nov 27, 2019
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants