Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy on speech bubble click #1062

Closed
wants to merge 1 commit into from
Closed

copy on speech bubble click #1062

wants to merge 1 commit into from

Conversation

sssoleileraaa
Copy link
Contributor

Description

Adds copy on message bubble click.

Resolves #1052
Does not fix #815

After testing with some of the strings provided by https://github.com/minimaxir/big-list-of-naughty-strings/blob/master/blns.txt (thanks @redshiftzero for the link) I see that #1050 won't be ready for a while (just try with one of our test data strings, e.g. https://github.com/freedomofpress/securedrop-client/wiki/Message-Test-Data#105127-character-image-url), so I created this spike to implement message-copy by clicking on speech bubbles. This isn't a full-fledged feature. There is no current hover or active state when you click on a speech bubble, so there is no indicator that the text was copied to the clipboard.

I could add a popup that says "Copied!" or something, but I wanted to open up this PR so people like @eloquence could take a look and provide feedback about using this as an interim solution while we continue to investigate issues found in #1050.

Test Plan

  1. Click on a speech bubble
  2. Ctrl-P in the ReplyBox to see that it was copied to the clipboard

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

@sssoleileraaa
Copy link
Contributor Author

Meant to open this as a WIP to get UX feedback from @ninavizz and @eloquence while #1050 is worked on. This still need tests, but will wait to see if this is an acceptable solution to allow copy paste in the client.

@sssoleileraaa
Copy link
Contributor Author

Closing because a different solution was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking upstream issue QTBUG-85498 Enable selecting and copying text in message/reply bubbles
1 participant