Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests localization and documents preflight check #1401

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

cfm
Copy link
Member

@cfm cfm commented Jan 25, 2022

Description

Closes #1398 by:

  1. testing that the Client appears translated when run under a (translated) valid $LANG; and
  2. adding a manual check for (1) in preflight testing.

Test Plan

  • CI passes, especially including the tests added here.
  • The preflight check suggested in the release template is reasonable (and this is a reasonable place for it).

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@cfm cfm added the i18n label Jan 25, 2022
@cfm cfm marked this pull request as ready for review January 26, 2022 00:18
@cfm cfm requested a review from a team as a code owner January 26, 2022 00:18
@cfm cfm added this to Ready for Review in SecureDrop Team Board Jan 26, 2022
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit 8f00027 into main Jan 26, 2022
SecureDrop Team Board automation moved this from Ready for Review to Done Jan 26, 2022
@sssoleileraaa sssoleileraaa deleted the 1398-test-localization branch January 26, 2022 01:29
@sssoleileraaa sssoleileraaa mentioned this pull request Jan 26, 2022
26 tasks
@cfm cfm mentioned this pull request May 11, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

add test suite for running in a translated locale
2 participants