Unbreak export on Qubes OS R4.1 #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, @eloquence is the only other dev with the appropriate setup for testing with an environment that point to the 4.1 repos (I can work through the same steps that @eaon took to get a fresh install set up, but that might not happen this week, so it would be great if @eloquence could review this one) |
One smol legit test failure (and may need rebase to pick up #1499), once that's updated, looks good to merge! |
On templates using R4.1 tools, `qvm-open-in-vm` redirects stdout/stderr to `/dev/null`, so instead we call `qrexec-client-vm` directly Fixes securedrop-workstation#775
|
Rebased and test adapted 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On templates using R4.1 tools,
qvm-open-in-vmredirects stdout/stderr to/dev/null, so instead we callqrexec-client-vmdirectlyFixes freedomofpress/securedrop-workstation#775
Test Plan
In Qubes 4.0:
In Qubes 4.1, using our VM templates with Qubes R4.1 repositories (i.e. bullseye, buster with manual upgrade, or after in-place upgrade to 4.1):
Checklist