Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build-buster job #1499

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix CI build-buster job #1499

merged 1 commit into from
May 26, 2022

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented May 26, 2022

Description

There's some bug in which building from a sdist tarball doesn't work.
Given that we wanted to move away from that anyways, switch to just
specifying the path to the directory instead.

Needs freedomofpress/securedrop-builder#332 to work.

✨ @creviera for finding out the difference in behavior between the tarball and the directory builds!

Test Plan

  • CI passes (once s-d-p patch is merged)

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@legoktm legoktm requested a review from a team as a code owner May 26, 2022 03:57
There's some bug in which building from a sdist tarball doesn't work.
Given that we wanted to move away from that anyways, switch to just
specifying the path to the directory instead.

Needs <freedomofpress/securedrop-builder#332> to work.

Co-Authored-By: Gonzalo Bulnes Guilpain <gon.bulnes@fastmail.com>
@gonzalo-bulnes
Copy link
Contributor

I only touched the commit to sign it. 🔏

Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the directory instead of the tarball as PKG_PATH is equivalent in this case. We've discussed this option with @creviera, and making the switch will fix the main CI build, as well as unlock work in progress.

We may want to evaluate the option of specifying a tarball as a next step, but that doesn't need to block ongoing work.

Thanks @legoktm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants