-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timeouts for API calls from the client and use SDK for timeouts #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
force-pushed
the
sdk-timeouts
branch
3 times, most recently
from
May 13, 2019 12:29
a14ea4e
to
53b0696
Compare
heartsucker
force-pushed
the
sdk-timeouts
branch
2 times, most recently
from
May 14, 2019 09:19
b5c007d
to
953122c
Compare
sssoleileraaa
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥 Lotta "Fixes" in this PR 💥
Note: to test this, I updated setup_g
in journalist_app/__init__.py
to cause a timeout and saw the expected error message in the error status bar in the client.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323. Fixes #324. Fixes #325. Toward #326. Fixes #327.
This is the first pass that shows that we can easily remove the timeouts from the client. This is only toward #326 and doesn't fix it since we should add logic to extend the timeout to be even longer for very large files.
Blocked by freedomofpress/securedrop-sdk#80 (PR that adds timeouts to the SDK itself).Testing
To test this, login. Then, go into SD core, go into
journalist_app/api.py
, and insetup_g
addimport time; time.sleep(30)
. Save the file. Flask will refresh. Now all requests will be delayed by 30 seconds, and the SDK timeout is 20. This will cause all requests to raise a timeout error. Check the logs for the presence of this error.