Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

incorrect error message when downloading a file that 404s #30

Closed
redshiftzero opened this issue Oct 25, 2018 · 0 comments
Closed

incorrect error message when downloading a file that 404s #30

redshiftzero opened this issue Oct 25, 2018 · 0 comments
Labels
bug Something isn't working easy

Comments

@redshiftzero
Copy link
Contributor

When one downloads a submission with an invalid UUID, i.e.

172.17.0.1 - - [25/Oct/2018 21:17:25] "GET /api/v1/sources/submissions/0d9cf7dd-a0f9-475c-bf97-aa5c31c5cd9b/download HTTP/1.1" 404 -

we get an incorrect message like:

'Missing reply 0d9cf7dd-a0f9-475c-bf97-aa5c31c5cd9b'

it should say missing submission
@redshiftzero redshiftzero added bug Something isn't working easy labels Oct 25, 2018
@42B 42B mentioned this issue Oct 31, 2018
Merged
yatsenko-julia pushed a commit to yatsenko-julia/securedrop-sdk that referenced this issue Nov 1, 2018
fix freedomofpress#30: changed incorrect error message when downloadi…
6aca77c 
…ng a file that 404s
redshiftzero added a commit that referenced this issue Nov 9, 2018
@redshiftzero
Merge pull request #36 from yatsenko-julia/issue-30
e8b0c2f 
fix #30: changed incorrect error msg when downloading a file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@redshiftzero