Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

fix #30: changed incorrect error msg when downloading a file #36

Merged
merged 1 commit into from Nov 9, 2018
Merged

fix #30: changed incorrect error msg when downloading a file #36

merged 1 commit into from Nov 9, 2018

Conversation

yatsenko-julia
Copy link

@yatsenko-julia yatsenko-julia commented Oct 31, 2018 •
edited

Fix #30

@yatsenko-julia yatsenko-julia changed the title fix issue-30: changed incorrect error msg when downloading a file fix issue #30: changed incorrect error msg when downloading a file Oct 31, 2018
@42B
Copy link

42B commented Oct 31, 2018 •
edited

@yatsenko-julia

Your commit message doesn't use the proper format to automatically close #30 if/when this PR is merged. The problem seems to be the word "issue" that you are adding between "fix" and the issue number.

Adding something like "Fix #30" in your PR description should handle it (or some combination from the link below)

@yatsenko-julia yatsenko-julia changed the title fix issue #30: changed incorrect error msg when downloading a file fix #30: changed incorrect error msg when downloading a file Oct 31, 2018
@kushaldas kushaldas self-requested a review November 1, 2018 07:27
@kushaldas
Copy link
Contributor

@yatsenko-julia Can you please squash those two commits into one? After that I can merge.

@yatsenko-julia
Copy link
Author

@kushaldas As you requested I have squashed two commits into one.

@redshiftzero
Copy link
Contributor

thanks @yatsenko-julia!

@redshiftzero redshiftzero merged commit e8b0c2f into freedomofpress:master Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@heartsucker heartsucker heartsucker approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yatsenko-julia @42B @kushaldas @redshiftzero @heartsucker