Installs Buster-based SDW template RPM #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 20, 2019 17:14
The sig verification for dom0 RPM packages was failing, due to a regex problem with the validation lines. Presumably since F29 -> F30, SHA512 is now used, so we should honor both SHA256 and SHA512 checksums. We plan to decommission the S3-hosting strategy for distributing RPMs, but since I needed to make this change in order to upload the latest Buster template RPM, I'm submitting for inclusion into master.
Simply pulls in the package, to make it available to developers for further testing. No changes are made to SDW TemplateVM settings at this time, we're simply adding the package so it's available.
emkll
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Thanks for the changes, this works as expected:
-
make allon master (as of this PR) does not pull in the buster template -
make allon this branch pulls in the buster template. - securedrop-workstation-buster boots, and when hvm is enabled, the grsecurity kernel is running
- All tests pass when running
make test
We should note that once this is merged to master, any make all from master will pull in both templates, which will result in a one-time additional 5-10 minutes to the run, depending on network speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Refs #306. Closes #344.
Updates the Salt logic to pull in the latest, Buster-based template RPM. The artifact that should be installed is presented here: freedomofpress/securedrop-yum-test#3
Testing
In dom0: